Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Truck's default width & height are describing car's defaults #31

Closed
nilsnolde opened this issue Sep 28, 2022 · 1 comment · Fixed by #37
Closed

Truck's default width & height are describing car's defaults #31

nilsnolde opened this issue Sep 28, 2022 · 1 comment · Fixed by #37
Assignees
@nilsnolde

Comments

@nilsnolde
Copy link
Member

Just had a confusion about the costing defaults of the web app at valhalla/valhalla#3767. I realized we're swapping the defaults Valhalla uses for width & height. Quick fix.
@nilsnolde nilsnolde self-assigned this Sep 28, 2022
@nilsnolde
Copy link
Member Author

Sorry, had the wrong request. In fact, our network analyst has that similar problem 😅

The web app also has a problem though: it's assuming a width of 1.6 m and a height of 1.9 m for truck, while that configuration is the default for cars.

@nilsnolde nilsnolde changed the title Costing defaults of width & height are swapped Truck's default width & height are describing car's defaults Sep 28, 2022
nilsnolde added a commit that referenced this issue Nov 19, 2022
@nilsnolde
fixes #31
69db9ec
@nilsnolde nilsnolde mentioned this issue Nov 19, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@nilsnolde nilsnolde

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

set truck width & height properly gis-ops/valhalla-app
1 participant
@nilsnolde