add date-time option for easy testing conditional-turn-restriction

[nvcnvn]

👨‍💻 Changes proposed

• Add date-time picker (for easier testing time-based turn restriction)

📷 Screenshots

[nilsnolde]

Thanks, that'd be a nice addition which would make the app much more useful. A couple of comments:

• seems like it's now mandatory to give a date/time? Would be better if it was opt-in, e.g. the default item in the dropdown could be "Anytime" or so and a greyed out date/time field. WDYT?
• the moment library causes a build failure: https://github.com/gis-ops/valhalla-app/actions/runs/6637880358/job/18036721164?pr=200. Can you have a look?

[nvcnvn]

• seems like it's now mandatory to give a date/time? Would be better if it was opt-in, e.g. the default item in the dropdown could be "Anytime" or so and a greyed out date/time field. WDYT?

I just want to clarify the behavior of Valhalla in this case, should "Anytime" (empty date_time) different with "Current" (date_time.type = 0)?
Because most of the time we: A don't care about time, B want to test departure/arrival.

[nilsnolde]

Yes it will be different. If you say datetime.type = 0, then it’ll use the current time, ie time will be respected (incl restrictions, but also traffic if it’s loaded). When you don’t want to respect time, then you don’t send the date_time object in the request at all. And I agree, the latter will be the vast majority of requests.

[nilsnolde]

Thanks, I'll try it out soon. I'd also like to have @chrstnbwnkl opinion, who's much closer to react code than myself.

[chrstnbwnkl]

Thanks @nvcnvn , just a couple of comments!

[nvcnvn]

Thanks @nvcnvn , just a couple of comments!

Finally I found some time to update the PR.

[chrstnbwnkl]

Sorry for not getting back to this earlier... Looks like you forgot to check in the renamed datepicker component file?

[nvcnvn]

Sorry for not getting back to this earlier... Looks like you forgot to check in the renamed datepicker component file?

ah you are right

[chrstnbwnkl]

...and again sorry for the long wait. LGTM!