Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WIP :Throw appropriate exception when applying filters on stored but non-indexed field #415

Closed
wants to merge 4 commits into from
Closed

WIP :Throw appropriate exception when applying filters on stored but non-indexed field #415

wants to merge 4 commits into from

Conversation

MohamedHamouGisaia
Copy link
Member

Fix #357

@MohamedHamouGisaia MohamedHamouGisaia added this to the v10.6.0 milestone Mar 6, 2019
@MohamedHamouGisaia MohamedHamouGisaia self-assigned this Mar 6, 2019
@MohamedHamouGisaia MohamedHamouGisaia force-pushed the fix/not-indexed-field branch 2 times, most recently from 777493e to 628f071 Compare March 6, 2019 19:08
@MohamedHamouGisaia MohamedHamouGisaia changed the title Throw appropriate exception when applying filters on stored but non-indexed field WIP :Throw appropriate exception when applying filters on stored but non-indexed field Mar 7, 2019
laurent-thiebaud-gisaia
laurent-thiebaud-gisaia reviewed Mar 7, 2019
View reviewed changes
arlas-core/src/main/java/io/arlas/server/core/FluidSearch.java Outdated
@@ -205,6 +205,10 @@ private BoolQueryBuilder filter(Expression expression, String dateFormat) throws
throw new InvalidParameterException(INVALID_PARAMETER_F);
}
String field = expression.field;
FieldMD fieldMD = getFieldStatus(field);
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't really understand what is the difference between fieldMD and fieldStatus, why is not always the same?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I first called it FieldStatus before renaming it to FieldMD. I forgot to rename it everywhere

@MohamedHamouGisaia MohamedHamouGisaia removed this from the v10.6.0 milestone Mar 28, 2019
@sfalquier
Copy link
Contributor

Still working on it? Maybe it could be rebased/merged or closed?

@sfalquier
Copy link
Contributor

@MohamedHamouGisaia Should we close this PR?

@alainbodiguel alainbodiguel deleted the fix/not-indexed-field branch March 2, 2022 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@laurent-thiebaud-gisaia laurent-thiebaud-gisaia laurent-thiebaud-gisaia left review comments

@sfalquier sfalquier Awaiting requested review from sfalquier

@mbarbet mbarbet Awaiting requested review from mbarbet

@sylvaingaudan sylvaingaudan Awaiting requested review from sylvaingaudan

Assignees

@MohamedHamouGisaia MohamedHamouGisaia

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Throw appropriate exception when applying filters on non-indexed fields
3 participants
@MohamedHamouGisaia @sfalquier @laurent-thiebaud-gisaia