Add python 3.6 #10
Merged
Add python 3.6 #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ecarreras
previously requested changes
May 25, 2017
| @@ -15,7 +15,7 @@ def run(self): | |||
| """Comença la tasca de neteja.""" | |||
| _clean.run(self) | |||
| if os.path.exists(self.build_base): | |||
| print "Cleaning %s dir" % self.build_base | |||
| print("Cleaning {} dir".format(self.build_base)) | |||
There was a problem hiding this comment.
Això no et funcionarà amb python2.7 si no fas un import que sigui:
from __future__ import print_statement
|
Changes Unknown when pulling b92e55c on test_python_3.6 into ** on master**. |
|
For now I will change that tests on py3 not are mandatory adding this to the matrix:
fast_finish: true
allow_failures:
- python: "3.6" |
|
@ecarreras I wouldn't close this PR because the purpose of it is to make the library working with python3.6. |
ecarreras
approved these changes
Dec 1, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #9
This PR is to make the library compatible with python 3.6