-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Python 3 support #26
Comments
Hi, I m just dropping a note here to give a pointer to https://wily.readthedocs.io/en/latest/ |
Thanks for the pointer @asmodehn. I was not aware of this tool yet. |
I ran a quick update of the current HAROS version from to Python3 to see if I would run into any problems: |
@max-krichenbauer Thanks for trying it out! I figured most of the changes would be due to the iterators and some imports, but I am glad that there is some confirmation now. |
I'm interested in using this package in ROS Noetic (Python3 only). @git-afsantos is Python3 support something that is in the roadmap of haros ? do you foresee any blocker for this moving forward? I'm not familiar with haros but can maybe give a hand in the porting/testing if it's something that you're interested in supporting/releasing in Noetic. |
@mikaelarguedas Python3 is definitely going to be added sometime in the future (soon™). One of the pending goals is to add support for ROS2, which also requires Python3, so I will have to do it. |
@mikaelarguedas I have gone through the code of HAROS, bonsai, and some HAROS plugins (1, 2, 3, 4) to try and make them compatible with Python 3. After running a few preliminary tests, I think most of the issues should be gone. In any case, if you are willing, you could try running HAROS from source, and let me know if you run into any problems on your machine. Be sure to check out the If everything goes well, I should be able to open a PR and make a release for this version. |
That's awesome thanks! I'll give it a try over the weekend |
@git-afsantos I could get a python3 version running based on the |
Thanks for your contribution, @mikaelarguedas ! 👍 |
I needed some small changes for @max-krichenbauer's Should |
No, @ipa-hsd. |
The changes to support Python 3 have been merged in #109, and released as HAROS v3.10.4 . |
Python 2.7 will reach the end of its life on January 1st, 2020.
The text was updated successfully, but these errors were encountered: