support Windows colors #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wadackel
reviewed
Feb 28, 2018
cmd/git-chglog/initializer.go
Outdated
| @@ -30,7 +31,7 @@ func NewInitializer( | |||
| return &Initializer{ | |||
| ctx: ctx, | |||
| fs: fs, | |||
| logger: NewLogger(ctx.Stdout, ctx.Stderr, false, false), | |||
| logger: NewLogger(colorable.NewColorableStdout(), colorable.NewColorableStderr(), false, false), | |||
There was a problem hiding this comment.
I'd like to use InitContext.Stdout (and .Stderr) in NewInitializer, but do you have any special reasons?
There was a problem hiding this comment.
You are right. Reverted this part.
wadackel
added
type: bug
since InitContext should have Stdout/Stderr which is set as colorable
Pull Request Test Coverage Report for Build 27
💛 - Coveralls |
|
@mattn Thank you for fixing! merged 👍 |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this do / why do we need it?
git-chglog does not support Windows colors.
How this PR fixes the problem?
be nice
What should your reviewer look out for in this PR?
use go-colorable instead of native os.Stdout/os.Stderr. This doesn't break on Linux or macOS.
Check lists
Tests on Windows are already broken.