Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New template and pass all the test cases with windows! and usability update. #11

Merged
merged 4 commits into from
Mar 2, 2018

Conversation

wadackel
Copy link
Member

@wadackel wadackel commented Mar 1, 2018

What does this do / why do we need it?

For v0.2.0.

How this PR fixes the problem?

The specification of the file path in the test case is supported for windows.

What should your reviewer look out for in this PR?

  • None

Check lists

  • Test passed
  • Coding style (indentation, etc)

Additional Comments (if any)

  • None

Which issue(s) does this PR fix?

Related: #10
Related: #9

@wadackel wadackel added type: bug Something isn't working type: feature New feature or request type: refactoring Refactoring source code or architecture labels Mar 1, 2018
@wadackel wadackel self-assigned this Mar 1, 2018
@coveralls
Copy link

Pull Request Test Coverage Report for Build 42

  • 191 of 203 (94.09%) changed or added relevant lines in 5 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage increased (+0.7%) to 73.097%

Changes Missing Coverage Covered Lines Changed/Added Lines %
cmd/git-chglog/main.go 0 1 0.0%
cmd/git-chglog/template_builder.go 0 4 0.0%
cmd/git-chglog/kac_template_builder.go 79 86 91.86%
Files with Coverage Reduction New Missed Lines %
cmd/git-chglog/template_builder.go 2 0.0%
Totals Coverage Status
Change from base Build 32: 0.7%
Covered Lines: 1258
Relevant Lines: 1721

💛 - Coveralls

@wadackel wadackel merged commit d3f14a3 into master Mar 2, 2018
@wadackel wadackel deleted the develop branch March 2, 2018 00:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Something isn't working type: feature New feature or request type: refactoring Refactoring source code or architecture
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants