You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
I don't know much about git so I had no idea I could not use a space in a branch name. Git Cola's Create Branch dialog just threw a "git branch" returned exit status "128" error in my face and I had no idea why.
Please present a nicer message to the user, eg "Branch names cannot contain spaces" or "Invalid characters in branch name" or something. :)
The text was updated successfully, but these errors were encountered:
davvid
added a commit
to davvid/git-cola
that referenced
this issue
Feb 22, 2018
The "Create Branch" line edit has a completion model that returns
existing refs, but excludes remote branches. The rationale is that we
might want to tweak an existing refname and use it as the base when
creating a new branch name.
Related-to: git-cola#765
Signed-off-by: David Aguilar <davvid@gmail.com>
davvid
added a commit
to davvid/git-cola
that referenced
this issue
Feb 22, 2018
* usability:
doc/relnotes: update v3.1 release notes draft
createbranch: prevent invalid branch names
completion: add a GitCreateBranchLineEdit class
completion: add a BranchValidator to validate branch names
completion: fix docstring typo
widgets: rename "Potential" to "Checkout" to match branch usage
doc: add Hannes to the credits
Closesgit-cola#765
Signed-off-by: David Aguilar <davvid@gmail.com>
Thanks for the heads-up. The input field now prevents invalid branch names so it shouldn't be possible to create branches with spaces (and other invalid characters) anymore.
I don't know much about git so I had no idea I could not use a space in a branch name. Git Cola's Create Branch dialog just threw a
"git branch" returned exit status "128"
error in my face and I had no idea why.Please present a nicer message to the user, eg "Branch names cannot contain spaces" or "Invalid characters in branch name" or something. :)
The text was updated successfully, but these errors were encountered: