Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Space in to-be-created branch name leads to '"git branch" returned exit status "128"' #765

Closed
kannes opened this issue Feb 21, 2018 · 1 comment
Closed

Space in to-be-created branch name leads to '"git branch" returned exit status "128"' #765

kannes opened this issue Feb 21, 2018 · 1 comment

Comments

@kannes
Copy link

kannes commented Feb 21, 2018

I don't know much about git so I had no idea I could not use a space in a branch name. Git Cola's Create Branch dialog just threw a "git branch" returned exit status "128" error in my face and I had no idea why.

Please present a nicer message to the user, eg "Branch names cannot contain spaces" or "Invalid characters in branch name" or something. :)
davvid added a commit to davvid/git-cola that referenced this issue Feb 22, 2018
@davvid
completion: add a BranchValidator to validate branch names
e1b894b 
Related-to: git-cola#765
Signed-off-by: David Aguilar <davvid@gmail.com>
davvid added a commit to davvid/git-cola that referenced this issue Feb 22, 2018
@davvid
completion: add a GitCreateBranchLineEdit class
744e88b 
The "Create Branch" line edit has a completion model that returns
existing refs, but excludes remote branches.  The rationale is that we
might want to tweak an existing refname and use it as the base when
creating a new branch name.

Related-to: git-cola#765
Signed-off-by: David Aguilar <davvid@gmail.com>
davvid added a commit to davvid/git-cola that referenced this issue Feb 22, 2018
@davvid
Merge branch 'usability'
c23080a 
* usability:
  doc/relnotes: update v3.1 release notes draft
  createbranch: prevent invalid branch names
  completion: add a GitCreateBranchLineEdit class
  completion: add a BranchValidator to validate branch names
  completion: fix docstring typo
  widgets: rename "Potential" to "Checkout" to match branch usage
  doc: add Hannes to the credits

Closes git-cola#765
Signed-off-by: David Aguilar <davvid@gmail.com>
@davvid davvid closed this as completed in 4b2149d Feb 22, 2018
@davvid
Copy link
Member

davvid commented Feb 22, 2018

Thanks for the heads-up. The input field now prevents invalid branch names so it shouldn't be possible to create branches with spaces (and other invalid characters) anymore.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@davvid @kannes