prefs: option to automatically load template commit #1013
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Add AUTOTEMPLATE constant to models/prefs.py - Set autotemplate to False in Defaults class Signed-off-by: Victor Nepveu <victor.nepveu@imt-atlantique.net>
- Add checkbox to automatically load commit template - Update autotemplate variable if a change is detected Signed-off-by: Victor Nepveu <victor.nepveu@imt-atlantique.net>
- Replace self.new_commitmsg with template commit message when reinitializing the commit message editor if AUTOTEMPLATE is True Signed-off-by: Victor Nepveu <victor.nepveu@imt-atlantique.net>
- If AUTOTEMPLATE is True, load the commit template when opening a new repository - Fix line length in widgets/prefs.py Signed-off-by: Victor Nepveu <victor.nepveu@imt-atlantique.net>
davvid
reviewed
Nov 19, 2019
cola/models/prefs.py
Outdated
| @@ -9,6 +9,7 @@ | |||
| from ..cmd import Command | |||
|
|
|||
|
|
|||
| AUTOTEMPLATE = "cola.commit.autotemplate" | |||
There was a problem hiding this comment.
Single quotes for consistency, please. This seems reasonable. One small note -- everywhere else we use just a single flat namespace for config values. e.g. cola.autoloadcommittemplate is more in-line with the rest of the config keys we use. In documentation we spell it as cola.autoloadCommitTemplate which helps the readability.
Please make sure this feature is documented in doc/git-cola.rst in the CONFIGURATION VARIABLES section.
There was a problem hiding this comment.
Suggested change
| AUTOTEMPLATE = "cola.commit.autotemplate" | |
| AUTOTEMPLATE = "cola.autoloadcommittemplate" |
I used this format because of your comment (see #735 (comment))
There was a problem hiding this comment.
Ah, sorry for not remembering. Thanks for the updates.
- Change name to further consistency - Change double quotes to single quotes - Document the variable
davvid
added a commit
that referenced
this pull request
Nov 19, 2019
Signed-off-by: David Aguilar <davvid@gmail.com>
davvid
added a commit
that referenced
this pull request
Nov 19, 2019
* vnepveu/issue735: Modify and document AUTOTEMPLATE variable preferences: load template when opening repo preferences: replace commit message with template preferences: automatically load commit template preferences: add autotemplate variable Signed-off-by: David Aguilar <davvid@gmail.com>
bmwiedemann
added a commit
to bmwiedemann/openSUSE
that referenced
this pull request
Nov 28, 2019
https://build.opensuse.org/request/show/751369 by user dimstar_suse - Update to 3.6 - Usability, bells and whistles * The remote editor is much faster since it no longer queries remotes, and uses the cached information instead. git-cola/git-cola#986 * Commit message templates can now be loaded automatically by setting ``git config cola.autoloadcommittemplate true``. git-cola/git-cola#1013 git-cola/git-cola#735 * The UI layout can now be reset back to its initial state by selecting the "Reset Layout" action. This reverts the layout to the same state as when the app first launched. git-cola/git-cola#1008 git-cola/git-cola#994 * Files can now be ignored in either the project's `.gitignore`, or in the repository's priv
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #735