Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

No need to check remote on delete #986

Closed
WanWizard opened this issue Aug 31, 2019 · 3 comments
Closed

No need to check remote on delete #986

WanWizard opened this issue Aug 31, 2019 · 3 comments
Labels

Comments

@WanWizard
Copy link

@WanWizard WanWizard commented Aug 31, 2019

Now it tries to contect the remote when you press the "-" to delete it, which takes an absolute age when the remote can't be reached for whatever reason. The UI hangs on "Gathering info for "", for several minutes, before finally continuing with the delete.

Not sure why it tries to contact the remote when you want to delete it?

git-cola version: current master.

@davvid

This comment has been minimized.

Copy link
Member

@davvid davvid commented Sep 7, 2019

Is this in the Branches widget? When deleting remote branches we actually delete them on the server. But local branches should be instant. Unfortunately, yes, we do block on this operation. It would be good to not do that, and will require a bit of refactoring.

@WanWizard

This comment has been minimized.

Copy link
Author

@WanWizard WanWizard commented Sep 7, 2019

No, this is not about branches, but about the remote repo definitions (menu - File - Edit Remotes).

I have a local repo with 4 remotes: our gitolite server, the clients github account, the staging server and the production server. The client changed hosting providers, so I created new entries for staging and production (so I could test those).

After the new servers went live, I wanted to delete the remotes for the old servers, which took absolute ages because it tried to contact those remotes (which failed, the servers were gone at that point).

So: to be able to delete a remote you need to select the remote first. Selecting the remote contacts the remote (the section on the right says "Gathering info on <remotename>...", and this fails if the remote no longer exists (you need to wait for a timeout).

@davvid davvid closed this in 7bc4078 Nov 27, 2019
@davvid

This comment has been minimized.

Copy link
Member

@davvid davvid commented Nov 27, 2019

Nice catch, thanks for the report.

bmwiedemann pushed a commit to bmwiedemann/openSUSE that referenced this issue Nov 28, 2019
https://build.opensuse.org/request/show/751369
by user dimstar_suse
- Update to 3.6
- Usability, bells and whistles
* The remote editor is much faster since it no longer queries
  remotes, and uses the cached information instead.
  git-cola/git-cola#986
* Commit message templates can now be loaded automatically by setting
  ``git config cola.autoloadcommittemplate true``.
  git-cola/git-cola#1013
  git-cola/git-cola#735
* The UI layout can now be reset back to its initial state by selecting
  the "Reset Layout" action.  This reverts the layout to the same state
  as when the app first launched.
  git-cola/git-cola#1008
  git-cola/git-cola#994
* Files can now be ignored in either the project's `.gitignore`, or in the
  repository's priv
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.