Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Only use line buffering in text mode when calling Popen #1014

Merged
merged 1 commit into from Nov 19, 2019

Conversation

@SimonPe
Copy link
Contributor

SimonPe commented Nov 18, 2019

Python3.8 started complaining loudly when trying to open a stream in binary mode but with line buffering enabled.
So we should only try to set bufsize to 1 when we enable text or universal_newlines mode.

see https://docs.python.org/3/library/subprocess.html#subprocess.Popen under bufsize

Python3.8 started complaining loudly when trying to open a stream in binary mode but with line buffering enabled.
So we should only try to set `bufsize` to `1` when we enable `text` or `universal_newlines` mode.

see https://docs.python.org/3/library/subprocess.html#subprocess.Popen under bufsize
@davvid davvid merged commit ed00653 into git-cola:master Nov 19, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
davvid added a commit that referenced this pull request Nov 19, 2019
Signed-off-by: David Aguilar <davvid@gmail.com>
davvid added a commit that referenced this pull request Nov 19, 2019
* SimonPe/patch-1:
  Only use line buffering in text mode when calling Popen

Signed-off-by: David Aguilar <davvid@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.