Added AppData.xml files for Linux software gallery integration #627
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
See https://build.opensuse.org/request/show/441090 for an integration test. |
davvid
requested changes
Nov 20, 2016
There was a problem hiding this comment.
Looks good. Two small tweaks --
setup.pyneeds updating so that the appdata xml files gets installed. Does this only need to exist in the source tree, or does it need to exist in the install? I'm assuming we need it in the install.- capitalize "git" in the summary field.
|
I've added the requested changes in this branch, not tested though |
|
Works: https://build.opensuse.org/request/show/441903 Thanks. |
davvid
added a commit
that referenced
this pull request
Nov 25, 2016
Add appdata.xml files for the Linux Software Gallery. * vdragon/appdata: Add appdata.xml files. (cont.) Add appdata.xml files. Closes #627 References: https://people.freedesktop.org/~hughsient/appdata/ Signed-off-by: David Aguilar <davvid@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://people.freedesktop.org/~hughsient/appdata/ for more information.