New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added AppData.xml files for Linux software gallery integration #627

Merged
merged 1 commit into from Nov 25, 2016

Conversation

Projects
None yet
3 participants
@Mailaender
Contributor

Mailaender commented Nov 20, 2016

@Mailaender

This comment has been minimized.

Show comment
Hide comment
Contributor

Mailaender commented Nov 20, 2016

See https://build.opensuse.org/request/show/441090 for an integration test.

@davvid

Looks good. Two small tweaks --

  • setup.py needs updating so that the appdata xml files gets installed. Does this only need to exist in the source tree, or does it need to exist in the install? I'm assuming we need it in the install.
  • capitalize "git" in the summary field.
@Vdragon

This comment has been minimized.

Show comment
Hide comment
@Vdragon

Vdragon Nov 24, 2016

Contributor

I've added the requested changes in this branch, not tested though
https://github.com/Vdragon/git-cola/tree/appdata

Contributor

Vdragon commented Nov 24, 2016

I've added the requested changes in this branch, not tested though
https://github.com/Vdragon/git-cola/tree/appdata

@Mailaender

This comment has been minimized.

Show comment
Hide comment
Contributor

Mailaender commented Nov 24, 2016

@davvid davvid merged commit 18e551b into git-cola:master Nov 25, 2016

1 check passed

continuous-integration/travis-ci/pr The Travis CI build passed
Details

davvid added a commit that referenced this pull request Nov 25, 2016

Merge branch 'vdragon/appdata'
Add appdata.xml files for the Linux Software Gallery.

* vdragon/appdata:
  Add appdata.xml files.  (cont.)
  Add appdata.xml files.

Closes #627
References: https://people.freedesktop.org/~hughsient/appdata/
Signed-off-by: David Aguilar <davvid@gmail.com>

@Mailaender Mailaender deleted the Mailaender:appdata branch Nov 25, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment