Symmetric DAG #656
Merged
Symmetric DAG #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Efimov Vasily <real@ispras.ru>
…ation Currently, DAG orientation along x-axis could be easily turned by changing sign of x_off attribute. So, row allocation algorithm must adapt to current x_off value during prevention of label overlapping. Signed-off-by: Efimov Vasily <real@ispras.ru>
Currently, frontier value for newly allocated column is chosen using right most frontier value. New approach is to search for nearest allocated column and use its frontier. The patch also is required by consequent symmetric column allocation introduced in consequent patches because no column may exists at left side of currently allocating one. Signed-off-by: Efimov Vasily <real@ispras.ru>
Signed-off-by: Efimov Vasily <real@ispras.ru>
The patch adds optional desired column index argument for column allocation method. Signed-off-by: Efimov Vasily <real@ispras.ru>
Signed-off-by: Efimov Vasily <real@ispras.ru>
Signed-off-by: Efimov Vasily <real@ispras.ru>
laerreal
force-pushed
the
symmetric_dag
branch
from
09c5c9c
to
a657a94
Compare
davvid
added a commit
to davvid/git-cola
that referenced
this pull request
Feb 2, 2017
* laerreal/symmetric_dag: dag: update column allocation algorithm description dag: make branches do not jump far from fork's column dag: rework column allocation algorithm dag: allocate columns in both left and right directions dag: change initial frontier selection heuristic dag: prevent tag label overlapping with respect to current DAG orientation dag: keep maximum and minimum column index value Signed-off-by: David Aguilar <davvid@gmail.com>
|
Awesome, thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current column allocation algorithm is too straightforward. It results in following issues.
Graph inclines towards one direction. I think symmetric DAG would appear more pretty.
Graph is spread enought after merging of many parallel branches. In such situation new branches may jump far enough from its forks because the fork column is far from 0 column and there is free column near 0.
The patch series targets mostly this issues.
Changing of graph alignment in commit 02818e2 breaks tag label overlapping prevention algorithm. The patch dd164d1 improves the algorithm to be adaptive to current graph alignment.