Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lightweight tag & git.closest.tag.name ? #221

Closed
jcnoir opened this issue Nov 10, 2015 · 2 comments
Closed

Lightweight tag & git.closest.tag.name ? #221

jcnoir opened this issue Nov 10, 2015 · 2 comments
Labels
Milestone

Comments

@jcnoir
Copy link

jcnoir commented Nov 10, 2015

I use this plugin with lightweight tags.
I configure the pom.xml like this :

<gitDescribe>
<tags>true</tags>
</gitDescribe>

In the generated git.properties file :

  • git.tags : OK (points to the last lightweight tag)
  • git.closest.tag.name : points to the last annotated tag and not the last lightweight tag.

Is there a way to get the last lightweight tag in the git.closest.tag.name property ?

Thanks for this nice plugin !

@TheSnoozer
Copy link
Collaborator

Hi Thanks for reporting your Problem here.
I'll try to setup a small project to reproduce the Problem the have...stay tuned for updates!! :-)

@TheSnoozer TheSnoozer added the bug label Jun 8, 2016
@TheSnoozer TheSnoozer added feature and removed bug labels Jul 26, 2017
TheSnoozer pushed a commit to TheSnoozer/git-commit-id-maven-plugin that referenced this issue Sep 30, 2017
TheSnoozer pushed a commit to TheSnoozer/git-commit-id-maven-plugin that referenced this issue Oct 16, 2017
TheSnoozer pushed a commit to TheSnoozer/git-commit-id-maven-plugin that referenced this issue Oct 16, 2017
TheSnoozer pushed a commit to TheSnoozer/git-commit-id-maven-plugin that referenced this issue Oct 17, 2017
…ag.count prefer annotated tags (like the discribe command) and also works with patterns like 'light*'
@TheSnoozer
Copy link
Collaborator

TheSnoozer commented Oct 19, 2017

the closest tag and clostest.tag.count will be determined based on properties configured inside the git-describe command:

<gitDescribe>
<tags>true</tags>
</gitDescribe>

will cause that lightweight tags are also included for the closest tags

Also the pattern used inside the gitDescribe might have an impact on the resulting git.closest.tag.name and git.closest.tag.count

Feature will be available in 2.2.4

@TheSnoozer TheSnoozer added this to the 2.2.4 milestone Oct 19, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants