Skip to content

Feature/221 and Testcleanup (in particular remove the Whitebox class that was borrowed from mockito) #332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Oct 19, 2017
Merged

Feature/221 and Testcleanup (in particular remove the Whitebox class that was borrowed from mockito) #332

merged 5 commits into from
Oct 19, 2017

Conversation

@TheSnoozer
Copy link
Collaborator

@TheSnoozer TheSnoozer commented Oct 17, 2017 •
edited
Loading

Refs #221

Was implemented in a way that the closest tag and clostest.tag.count will be determined based on properties configured inside the git-describe command.

E.g.:

<gitDescribe>
<tags>true</tags>
</gitDescribe>

will cause that lightweight tags are also included for the closest tags

Also the pattern used inside the gitDescribe might have an impact on the resulting git.closest.tag.name and git.closest.tag.count

TheSnoozer added 5 commits October 16, 2017 00:23
git-commit-id#221: use gitDescribeConfig to determine the git.closest…
c714120 
….tag.name and git.closest.tag.count
cleanup test and introduce a common method that verifies if a key is …
311e7ce 
…present inside the properties and matches a specific value
replace alterMojoSettings with proper method calls and remove the org…
a984c2b 
…/mockito/internal/util/reflection/Whitebox
declare setters as @VisibleForTesting instead of just plain public
f3db1d4
git-commit-id#221: ensure that git.closest.tag.name and git.closest.t…
3d12d1d 
…ag.count prefer annotated tags (like the discribe command) and also works with patterns like 'light*'
@TheSnoozer TheSnoozer added this to the 2.2.4 milestone Oct 17, 2017
@TheSnoozer TheSnoozer merged commit 88378e0 into git-commit-id:master Oct 19, 2017
@TheSnoozer TheSnoozer deleted the feature/221 branch October 19, 2017 16:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

2.2.4

Development

Successfully merging this pull request may close these issues.

1 participant

@TheSnoozer