Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent recursion in _die() #26

Merged
merged 1 commit into from
Jan 28, 2013
Merged

Prevent recursion in _die() #26

merged 1 commit into from
Jan 28, 2013

Conversation

burak
Copy link
Member

@burak burak commented Jan 28, 2013

which in turn might call _die() to handle errors.
This will result with some meaningless errors as the
actual error will not reach the screen.

which in turn might call _die() to handle errors.
This will result with some meaningless errors as the
actual error  will not reach the screen.
@demerphq
Copy link
Member

I thought I already fixed this upstream Burak.

Yves

On 28 January 2013 14:19, Burak Gürsoy notifications@github.com wrote:

which in turn might call _die() to handle errors.
This will result with some meaningless errors as the
actual error will not reach the screen.


You can merge this Pull Request by running

git pull https://github.com/burak/git-deploy master

Or view, comment on, or merge it at:

#26

Commit Summary

Safegueard against recursion.__log() calls _get_config()

File Changes

M lib/Git/Deploy/Say.pm (27)

Patch Links:

https://github.com/git-deploy/git-deploy/pull/26.patch
https://github.com/git-deploy/git-deploy/pull/26.diff

perl -Mre=debug -e "/just|another|perl|hacker/"

avar added a commit that referenced this pull request Jan 28, 2013
Prevent recursion in _die()

Looks good to me, tested it on the csapp box with a syntax error in git-deploy.conf.
@avar avar merged commit d80c5f5 into git-deploy:master Jan 28, 2013
@avar
Copy link
Member

avar commented Jan 28, 2013

Nah, it was still broken for the case where the git-deploy.conf had a syntax error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants