Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update support for Bitbucket Server #141

Closed

Conversation

dscho
Copy link
Collaborator

@dscho dscho commented Jun 26, 2020

No description provided.

…vier for an arbitrary host, i.e. a Bitbucket Server host

Allow HTTP as well as HTTPS for Bitbucket Server hosts

TODO test more complex URLs e.g. https://my.company.com/bitbucket
…. Save with and without usernames since BbS doesn't generally include them in its Git URLs
@dscho
Copy link
Collaborator Author

dscho commented Jun 26, 2020

There, now we get PR builds and can merge ;-)

Copy link
Collaborator

@mjcheetham mjcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except some minor changes to the name of some of the methods, and nit picking on spaces between if and (.

src/shared/Atlassian.Bitbucket/BitbucketHostProvider.cs Outdated Show resolved Hide resolved
src/shared/Atlassian.Bitbucket/BitbucketHostProvider.cs Outdated Show resolved Hide resolved
src/shared/Atlassian.Bitbucket/BitbucketHostProvider.cs Outdated Show resolved Hide resolved
src/shared/Atlassian.Bitbucket/BitbucketHostProvider.cs Outdated Show resolved Hide resolved
src/shared/Atlassian.Bitbucket/BitbucketHostProvider.cs Outdated Show resolved Hide resolved
src/shared/Atlassian.Bitbucket/BitbucketHostProvider.cs Outdated Show resolved Hide resolved
src/shared/Atlassian.Bitbucket/BitbucketHostProvider.cs Outdated Show resolved Hide resolved
@mjcheetham mjcheetham linked an issue Jun 26, 2020 that may be closed by this pull request
@dscho
Copy link
Collaborator Author

dscho commented Jun 26, 2020

I guess I should have let @mminns open the PR, so that the checkbox "allow maintainers to edit" is there, and can be checked...

My fault, sorry!!!

mminns and others added 7 commits June 26, 2020 15:15
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
mjcheetham added a commit to mjcheetham/git-credential-manager that referenced this pull request Jun 29, 2020
…-basicauth

Update support for Bitbucket Server
@dscho
Copy link
Collaborator Author

dscho commented Jun 29, 2020

It seems that there was a technical glitch that did not mark this as merged, even if it was merged. I'll just close it. Thank you, @mminns!

@dscho dscho closed this Jun 29, 2020
@mminns mminns deleted the issue/support-bbs-basicauth branch June 29, 2020 12:40
@mjcheetham mjcheetham mentioned this pull request Jul 17, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Extend the Bitbucket Provider to support Bitbucket Server instances
3 participants