-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update support for Bitbucket Server #141
Update support for Bitbucket Server #141
Conversation
…vier for an arbitrary host, i.e. a Bitbucket Server host Allow HTTP as well as HTTPS for Bitbucket Server hosts TODO test more complex URLs e.g. https://my.company.com/bitbucket
…. Save with and without usernames since BbS doesn't generally include them in its Git URLs
There, now we get PR builds and can merge ;-) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, except some minor changes to the name of some of the methods, and nit picking on spaces between if
and (
.
I guess I should have let @mminns open the PR, so that the checkbox "allow maintainers to edit" is there, and can be checked... My fault, sorry!!! |
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
Co-authored-by: Matthew John Cheetham <mjcheetham@github.com>
…-basicauth Update support for Bitbucket Server
It seems that there was a technical glitch that did not mark this as merged, even if it was merged. I'll just close it. Thank you, @mminns! |
No description provided.