Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable OAuth device authorisation grant support for GitHub #147

Merged
merged 2 commits into from
Jul 17, 2020
Merged

Enable OAuth device authorisation grant support for GitHub #147

merged 2 commits into from
Jul 17, 2020

Conversation

mjcheetham
Copy link
Collaborator

☝️ Auth to GitHub via OAuth in a headless environment will work now! 🥳

@mjcheetham mjcheetham added host:github Specific to the GitHub host provider auth:oauth Specific to OAuth2 authentication labels Jul 16, 2020
derrickstolee
derrickstolee approved these changes Jul 16, 2020
View reviewed changes
Copy link
Contributor

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't done a manual test here, but this looks good! What a milestone.

dscho
dscho approved these changes Jul 17, 2020
View reviewed changes
Copy link
Collaborator

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

From what little I understand of this code, this looks good to me!

@mjcheetham
github: use final OAuth device code endpoint
9acfcb3 
Use the final OAuth2 device authorization endpoint URI.
@mjcheetham
github: enable OAuth2 device code flow for GitHub
ecf36a3 
Enable the device code authorization grant flow for GitHub.
@mjcheetham mjcheetham merged commit 0525476 into git-ecosystem:master Jul 17, 2020
@mjcheetham mjcheetham deleted the github-oauthdevice branch July 17, 2020 14:23
@mjcheetham mjcheetham mentioned this pull request Jul 17, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dscho dscho dscho approved these changes

@derrickstolee derrickstolee derrickstolee approved these changes

Assignees
No one assigned
Labels
auth:oauth Specific to OAuth2 authentication host:github Specific to the GitHub host provider
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@mjcheetham @dscho @derrickstolee