Release 2.5.1 #1648
Merged
Release 2.5.1 #1648
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NuGet requires that signed packages have a matching registered signing certificate [1]. Update release workflow to capture this certificate from the Sign CLI tool and upload it as a release artifact. 1: https://learn.microsoft.com/en-us/nuget/create-packages/sign-a-package#register-the-certificate-on-nugetorg
NuGet requires that signed packages have a matching [registered signing certificate](https://learn.microsoft.com/en-us/nuget/create-packages/sign-a-package#register-the-certificate-on-nugetorg). Update release workflow to capture this certificate from the Sign CLI tool and upload it as a release artifact. Note that this means we will need to manually update this certificate to the [`git-credential-manager` organization](https://www.nuget.org/profiles/git-credential-manager) in nuget.org prior to publishing the .NET tool version for each release. Tested the end-to-end flow in [my fork](https://github.com/ldennington/git-credential-manager) which resulted in publication of [this package](https://int.nugettest.org/packages/git-credential-manager) to the NuGet QA Gallery.
Update the Managed Identity and Service Principal docs to include the reference to a known issue with some MI formats.
Update all our dependencies to the latest verisons: - MSAL 4.61.3 - Avalonia 11.0.11
Update all our dependencies to the latest versions: - MSAL 4.61.3 - Avalonia 11.0.11
Use the new azure/trusted-signing-action in place of the now deprecated azure/azure-code-signing-action. https://github.com/azure/azure-code-signing-action https://github.com/azure/trusted-signing-action
Use our customised version of the dotnet/sign tool for Trusted Signing, including export of the certificate.
) - Update to the latest version of the GitHub Action (the `azure/azure-code-signing-action` action has been replaced by the `azure/trusted-signing-action` one). - Deploy a forked version of the `Sign.Cli` tool for Trusted Signing, which includes the ability to export the certificate. The fork can be found here https://github.com/mjcheetham/sign/tree/export-opt, and the PR to submit this change upstream here dotnet/sign#734. With these changes we are now completely secret/credential free, and rely on federation only.
Use a 3rd party tool to extract the NuGet signing certificate for upload rather than relying on an option added to the sign.exe tool in a private fork.
Use the `dotnet tool install` command to acquire the code signing tool, rather than rely on our Azure blob store.
Drop the `-d` and `-u` options from the sign.exe CLI; they are no longer required.
…1647) Use a 3rd party tool to extract the NuGet signing certificate for upload rather than relying on an option added to the sign.exe tool in a private fork. At the same time let's use the `dotnet tool install` command to acquire the code signing tool, rather than rely on our Azure blob store. Also let's drop the `-d` and `-u` options from the sign.exe CLI; they are no longer required ([source](dotnet/sign#734 (comment))).
|
Failing centos 8 error is related to: cc @dscho |
dscho
approved these changes
Jul 2, 2024
Ah. That explains it all right! |
vdye
approved these changes
Jul 2, 2024
|
This version of CentOS is out of date, so I'm not going to bother investigating much further for this point-1 release. Until I have enough 'budget' to work on issues like this in GCM, I'm afraid I'll just need to merge with this check continuing to fail. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: