gitconfig: avoid deadlock on large amounts of config data #183
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
derrickstolee
approved these changes
Sep 25, 2020
kyle-rader
approved these changes
Sep 25, 2020
As per the Remarks section in https://docs.microsoft.com/en-us/dotnet/api/system.diagnostics.processstartinfo.redirectstandardoutput we should first read the output until the end before waiting for the `git config` process to finish, to avoid deadlocks. This indeed helps in the situation of this developer whose config is so large that `git config -l` produces 25 kilobyte worth of output. Apparently, this fills up some buffer that seems to be around 8kB and then `git config -l` waits for its output to be consumed, and before this patch, the consumer (i.e. GCM Core) would wait for `git config -l` to exit already.
dscho
force-pushed
the
avoid-deadlocks-when-reading-the-config
branch
from
a6c55f1
to
15c11c6
Compare
P.s., yes this exposed a bug in GCM Core, but perhaps you should consider trimming your config.. just a bit? 🤣 |
I know I have a lot of branches and remotes... But it's not my fault that git/git has so many forks that I need to keep track of! 😁 $ git remote -v | wc
58 174 3095
$ git config --get-regexp 'branch\..*\.remote' | wc
83 166 3682 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the problem I encountered today after upgrading from GCM Core v2.0.194.40577 to v2.0.246.34937: due to the sheer size of my repository config (
git config -lproduces over 25kB of data), the credential manager would just hang, waiting forgit configto be done, while the latter waited for the former to read its output.