Split Windows installer in to user/system flavours #197
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Split the Windows installer into two versions: a single-user installer, and a system-wide installer. The old installer installed in Program Files (x86) and set the system Git configuration, which is now what the system-flavoured installer does. The new single-user installer places files in %LOCALAPPDATA% and updates the ~/.gitconfig (global) user Git configuration instead. The benefit of the single-user installer is that it does not require an administrator to install it, and doesn't affect other users of the system.
mjcheetham
force-pushed
the
winstall-split
branch
from
97facf1
to
4f12cc7
Compare
mjcheetham
added
installation
derrickstolee
approved these changes
Oct 29, 2020
|
README.md needs to be updated with an explanation for this. I was initially very confused as to why there are two Windows binaries and which one I should install. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Split the Windows installer into two versions: a single-user installer, and a system-wide installer.
The old installer installed in Program Files (x86) and set the system Git configuration, which is now what the system-flavoured installer does.
The new single-user installer places files in %LOCALAPPDATA% and updates the ~/.gitconfig (global) user Git configuration instead.
The benefit of the single-user installer is that it does not require an administrator to install it, and doesn't affect other users of the system.
There will now be two installers for Windows:
gcmcore-win....andgcmcoreuser-win..... This is the same as VS Code.