Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Harmonise Microsoft Authentication APIs with AAD "v2" and MSAL concepts #277

Merged
merged 2 commits into from
Feb 3, 2021
Merged

Harmonise Microsoft Authentication APIs with AAD "v2" and MSAL concepts #277

merged 2 commits into from
Feb 3, 2021

Commits on Feb 2, 2021

  1. msauth: return MSAL wrapped result rather than JWT AT 

    Change the MSAuth GetToken method signature to return a wrapper result
object rather than just the JWT access token. The result wrapper object
includes the account UPN and the wrap AT as returned by MSAL. We do not
need to inspect the claims of the AT (which might not even by a JWT in
some cases anyway) since we have the account info elsewhere.
    @mjcheetham
    mjcheetham committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    216b2a8 View commit details
    Browse the repository at this point in the history

  2. msauth: rename resource to scopes and drop remote URI 

    Rename the resource parameter to the MSAuth component to scopes, which
is the AAD "v2" concept. Also drop the remote URI parameter which is no
longer needed.
    @mjcheetham
    mjcheetham committed Feb 2, 2021
    Configuration menu
    Copy the full SHA
    28fdf76 View commit details
    Browse the repository at this point in the history