Harmonise Microsoft Authentication APIs with AAD "v2" and MSAL concepts #277
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcheetham
added
engineering
mjcheetham
requested review from
dscho,
derrickstolee,
jeffhostetler and
bgavrilMS
Change the MSAuth GetToken method signature to return a wrapper result object rather than just the JWT access token. The result wrapper object includes the account UPN and the wrap AT as returned by MSAL. We do not need to inspect the claims of the AT (which might not even by a JWT in some cases anyway) since we have the account info elsewhere.
Rename the resource parameter to the MSAuth component to scopes, which is the AAD "v2" concept. Also drop the remote URI parameter which is no longer needed.
mjcheetham
force-pushed
the
msal-api-harmony
branch
from
5a51a6c
to
28fdf76
Compare
derrickstolee
approved these changes
Feb 2, 2021
There should be no behaviour changes at all. All I'm doing is removing a 'jump' method that turns the |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refactor the
MicrosoftAuthenticationcomponent API signature to accept a set of scopes (string[] scopes) rather than a single "resource ID", and drop the no-longer used remote URL parameter.Introduce a new wrapper type for the authentication result such that we can drop the dependency on the JWT library and not expose the MSAL
AuthenticationResulttype either. We only need the access token (as a string) and the account UPN.Note that technically before we should not have been trying to parse the access token as a JWT because there is no guarantee that STS returns JWTs - they should be treated transparently.