Target .NET Framework 4.7.2 and fix missing binaries in Windows installers #283
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcheetham
added
bug
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When we added support for
System.CommandLineI neglected to add the extra binaries it brings to the party in the Windows installers. D'oh!Given the
System.CommandLineis a .NET Standard targeting library, and we're currently targeting .NET Framework 4.6.1 on Windows, this brings in a lot of compatibility and shim/type forwarding binaries (sincenet461doesn't perfectly implementnetstandard2.0.. go figure). We've asked for them to consider targeting a downlevel net461 TFM, but in reality we can also just as easily increase our TFM tonet472, which doesn't require any of those shim binaries..NET Framework 4.7.2 is supported on Windows versions all the way back to Windows 7 SP1, so we won't be removing any users from the support matrix. Git for Windows supports Vista, but since GCM Core is already targeting
net461, it doesn't run on Vista today(!) Vista only supports 4.6(.0) as the latest Framework version.We could also drop the
System.CommandLineusage, but I'd rather not. It's worth it IMO.