Add Git credential cache as backing store on Linux #287
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcheetham
reviewed
Feb 15, 2021
src/shared/Microsoft.Git.CredentialManager/CredentialCacheStore.cs
Outdated
Show resolved
Hide resolved
src/shared/Microsoft.Git.CredentialManager/Interop/Linux/LinuxCredentialStore.cs
Outdated
Show resolved
Hide resolved
Co-authored-by: Matthew John Cheetham <mjcheetham@outlook.com>
Co-authored-by: Matthew John Cheetham <mjcheetham@outlook.com>
|
Tested on an Ubuntu 20.04 machine against a private Azure Repos instance. I don't have a clear idea of how or what needs unit testing, and suggestions would be most welcomed. |
mjcheetham
reviewed
Feb 19, 2021
There was a problem hiding this comment.
Looks good to me! Left a question on the value of the store option, and also we're missing updates to the other settings/reference docs for the new options.
In terms of unit tests.. I am not sure it's worth the effort here, given this is largely around process creation and stdin/out forwarding.
src/shared/Microsoft.Git.CredentialManager/Interop/Linux/LinuxCredentialStore.cs
Outdated
Show resolved
Hide resolved
env var for config is still the long form, but the git option is already namespaced to `credential` so it was also shortened.
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #261
git credential-cache exit, are credentials dropped?--timeoutvia environment variable works?