Run postinstall and uninstall configure commands as current user #308
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dscho
approved these changes
Mar 10, 2021
dscho
reviewed
Mar 10, 2021
mjcheetham
force-pushed
the
osx-noroot-postinstall
branch
from
3ce6700
to
e338991
Compare
In the macOS installer postinstall script we run the `configure` command to get GCM to configure the current user's credential helper as GCM. However, the postinstall script is often run as root (because that's how `installer` works out of the box), meaning although GCM will be writing to the ~/.gitconfig file, it will be doing so from a process running as root. To avoid having root take ownership of ~/.gitconfig we run `sudo -u` to run the `configure` command as the real user (not root).
mjcheetham
force-pushed
the
osx-noroot-postinstall
branch
from
e338991
to
2e207e9
Compare
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the macOS installer postinstall script we run the
configurecommand to get GCM to configure the current user's credential helper as GCM.However, the postinstall script is often run as root (because that's how
installerworks out of the box), meaning although GCM will be writing to the ~/.gitconfig file, it will be doing so from a process running as root.To avoid having root take ownership of ~/.gitconfig we run
sudo -uto run theconfigurecommand as the real user (not root).Also update the uninstall script to do the same thing (run
unconfigureas the non-root user).Fixes #186