Add support for Windows broker (WAM) #323
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mjcheetham
requested review from
dscho,
derrickstolee,
vtbassmatt and
jeffhostetler
mjcheetham
force-pushed
the
wam
branch
2 times, most recently
from
3579c91
to
af6d5c9
Compare
Add support for broker-assisted authentication on Windows using "WAM" (Web Authentication Manager) as provided by the MSAL.Desktop library. The GCM_MSAUTH_USEBROKER environment variable or the credential.msauthUseBroker configuration option will control if WAM is enabled or not. By default WAM _is_ enabled.
dscho
approved these changes
Apr 9, 2021
There was a problem hiding this comment.
Do we need to be worried about these warnings (StorageCreationPropertiesBuilder() being obsolete)?
src/shared/Microsoft.Git.CredentialManager/Authentication/MicrosoftAuthentication.cs
Show resolved
Hide resolved
src/shared/Microsoft.Git.CredentialManager/Authentication/MicrosoftAuthentication.cs
Show resolved
Hide resolved
src/shared/Microsoft.Git.CredentialManager/Authentication/MicrosoftAuthentication.cs
Show resolved
Hide resolved
Reorder the CanUseBroker logic to be easier to grok.
vtbassmatt
approved these changes
Apr 9, 2021
derrickstolee
approved these changes
Apr 10, 2021
src/shared/Microsoft.Git.CredentialManager/Authentication/MicrosoftAuthentication.cs
Outdated
Show resolved
Hide resolved
src/shared/Microsoft.Git.CredentialManager/Authentication/MicrosoftAuthentication.cs
Show resolved
Hide resolved
src/shared/Microsoft.Git.CredentialManager/Authentication/MicrosoftAuthentication.cs
Show resolved
Hide resolved
Improve the wording around which settings and values cause the auth-flow setting to be ignored. Grammer iz hard.
bgavrilMS
reviewed
Apr 12, 2021
src/shared/Microsoft.Git.CredentialManager/Authentication/MicrosoftAuthentication.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Apr 12, 2021
src/shared/Microsoft.Git.CredentialManager/Authentication/MicrosoftAuthentication.cs
Show resolved
Hide resolved
bgavrilMS
reviewed
Apr 12, 2021
bgavrilMS
reviewed
Apr 12, 2021
src/shared/Microsoft.Git.CredentialManager/Authentication/MicrosoftAuthentication.cs
Show resolved
Hide resolved
bgavrilMS
approved these changes
Apr 12, 2021
Remove the usage of a now deprecated constructor for the shared token cache storage properties. This constructor took the client ID which was only used to eventing; GCM doesn't use this.
@dscho I've removed the warnings by dropping that extra (not needed) argument from the constructor in question. |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add support for broker-assisted authentication on Windows using "WAM" (Web Authentication Manager) as provided by the MSAL.Desktop library.
The
GCM_MSAUTH_USEBROKERenvironment variable or thecredential.msauthUseBrokerconfiguration option will control if WAM is enabled or not.By default WAM is enabled.This ended up being simpler then I expected. Looks like the VS AAD app registration has now been updated to have the required WAM redirect URI which was previously a technical blocker.
Fixes #211
Update: WAM is now default disabled due to concerns about the maturity of the UX and technology. cc: @bgavrilMS