-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove 'core' from docs #541
Remove 'core' from docs #541
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for splitting up these mostly-mechanical changes by type! Made it a very easy read.
@@ -106,7 +106,7 @@ tar -xvf <path-to-tarball> -C /usr/local/bin | |||
git-credential-manager-core configure | |||
``` | |||
|
|||
**Note:** all Linux distributions [require additional configuration](https://aka.ms/gcmcore-credstores) to use GCM. | |||
**Note:** all Linux distributions [require additional configuration](https://aka.ms/gcm/credstores) to use GCM. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I didn't know we could have sub-directories in these links. Nice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Technically, there is more in that commit than just removing core
from the docs, but the changes are all good!
With the ongoing work to migrate GCM to its new org, we're taking the opportunity to update our references to GCM Core/GCM-Core in documentation to GCM. Note that this change is limited to documentation only - executables and assemblies will be updated at a later time.
Let me know if the new series looks better 馃檪 . |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great! Just one question about the Debian package ID, and theres a missing doc update and then we're good to go! Will approve pre-emptively.
Replacing references to microsoft/Git-Credential-Manager-Core with references to GitCredentialManager/git-credential-manager.
Update references to aka.ms/gcmcore-* to aka.ms/gcm/*.
Update gcm-test@example.com to gcm@example.com.
New org, new GCM! 馃帀 This change updates the docs with:
aka.ms/gcmcore-*
-->aka.ms/gcm/*
gcmcore-test@example.com
-->gcm-test@example.com