Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove 'core' from docs #541

Merged
merged 4 commits into from
Nov 19, 2021
Merged

Remove 'core' from docs #541

merged 4 commits into from
Nov 19, 2021

Conversation

ldennington
Copy link
Contributor

@ldennington ldennington commented Nov 18, 2021

New org, new GCM! 馃帀 This change updates the docs with:

  1. Git Credential Manager Core/GCM Core --> Git Credential Manager/GCM
  2. microsoft/Git-Credential-Manager-Core --> GitCredentialManager/git-credential-manager
  3. aka.ms/gcmcore-* --> aka.ms/gcm/*
  4. gcmcore-test@example.com --> gcm-test@example.com

Copy link
Contributor

@derrickstolee derrickstolee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for splitting up these mostly-mechanical changes by type! Made it a very easy read.

@@ -106,7 +106,7 @@ tar -xvf <path-to-tarball> -C /usr/local/bin
git-credential-manager-core configure
```

**Note:** all Linux distributions [require additional configuration](https://aka.ms/gcmcore-credstores) to use GCM.
**Note:** all Linux distributions [require additional configuration](https://aka.ms/gcm/credstores) to use GCM.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I didn't know we could have sub-directories in these links. Nice!

Copy link
Collaborator

@dscho dscho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Technically, there is more in that commit than just removing core from the docs, but the changes are all good!

With the ongoing work to migrate GCM to its new org, we're taking the
opportunity to update our references to GCM Core/GCM-Core in documentation
to GCM.

Note that this change is limited to documentation only - executables and
assemblies will be updated at a later time.
@ldennington
Copy link
Contributor Author

Nice!

Technically, there is more in that commit than just removing core from the docs, but the changes are all good!

Let me know if the new series looks better 馃檪 .

Copy link
Collaborator

@mjcheetham mjcheetham left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just one question about the Debian package ID, and theres a missing doc update and then we're good to go! Will approve pre-emptively.

src/linux/Packaging.Linux/build.sh Outdated Show resolved Hide resolved
docs/github-apideprecation.md Show resolved Hide resolved
Replacing references to microsoft/Git-Credential-Manager-Core with references
to GitCredentialManager/git-credential-manager.
Update references to aka.ms/gcmcore-* to aka.ms/gcm/*.
Update gcm-test@example.com to gcm@example.com.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants