New release #567
Merged
New release #567
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Show the terminal/TTY based prompts when there is no desktop/GUI sessions present for GitHub. Currently the Bitbucket and Microsoft auth stacks correctly detect the lack of a desktop session and use terminal prompts - GitHub does not. Without this change, SSH-ing in to a machine we'd still try and show a UI prompt where there is no way to interact with it!
The Debian package build script incorrectly copies the containing
directory to the destination tree rather than just the contents
recursively. This means we end up with:
usr
└── local
├── bin
│ ├── Atlassian.Bitbucket.UI -> ../share/gcm-core/Atlassian.Bitbucket.UI
│ ├── git-credential-manager-core -> ../share/gcm-core/git-credential-manager-core
│ └── GitHub.UI -> ../share/gcm-core/GitHub.UI
└── share
└── gcm-core
** ---> └── Release
├── Atlassian.Bitbucket.UI
├── git-credential-manager-core
├── GitHub.UI
├── libHarfBuzzSharp.so
├── libSkiaSharp.so
└── NOTICE
..rather than:
usr
└── local
├── bin
│ ├── Atlassian.Bitbucket.UI -> ../share/gcm-core/Atlassian.Bitbucket.UI
│ ├── git-credential-manager-core -> ../share/gcm-core/git-credential-manager-core
│ └── GitHub.UI -> ../share/gcm-core/GitHub.UI
└── share
└── gcm-core
├── Atlassian.Bitbucket.UI
├── git-credential-manager-core
├── GitHub.UI
├── libHarfBuzzSharp.so
├── libSkiaSharp.so
└── NOTICE
Since the symlinks are wrong, the installation is broken.
Remove the symlinks to the GitHub and Bitbucket UI helpers in /usr/local/bin. These are not required to have the core GCM application locate the helpers and just create more noise in the user's $PATH.
With the ongoing work to migrate GCM to its new org, we're taking the opportunity to update our references to GCM Core/GCM-Core in documentation to GCM. Note that this change is limited to documentation only - executables and assemblies will be updated at a later time.
Show GitHub terminal prompts when no GUI session
Replacing references to microsoft/Git-Credential-Manager-Core with references to GitCredentialManager/git-credential-manager.
Update references to aka.ms/gcmcore-* to aka.ms/gcm/*.
Drop "Core" from the social banner image
Fix Debian package build script copy command
Update gcm-test@example.com to gcm@example.com.
The CodeQL Results task has been hanging in Pull Requests in our new repo. Planning to remove and re-add via the GitHub UI in the hopes that will make the task work as expected.
workflows: remove CodeQL
Re-adding CodeQL to ensure all checks work as expected in new org/repo.
workflows: add CodeQL
Remove 'core' from docs
fixes #424
fixes #189
TODO include in GitHub actions etc setup, e.g. https://josh-ops.com/posts/github-code-coverage/, once microsoft/vstest#1811 is fixed
Co-authored-by: Matthew John Cheetham <mjcheetham@outlook.com>
Co-authored-by: Matthew John Cheetham <mjcheetham@outlook.com>
Co-authored-by: Matthew John Cheetham <mjcheetham@outlook.com>
Batch of documentation fixes
Fix a MD table that was not rendering correctly.
Add basic support for generating code coverage reports
small formatting issues in uninstall section for linux.
Fix setx command
Update README.md
Update the new issue templates with the extra required WSLENV environment variable that is required for passing trace envars to the Windows host.
Update issue template for WSL tracing
mjcheetham
approved these changes
Dec 10, 2021
Whoops! I may have gone a little overboard. Should I remove the additional changes I added? |
Not an issue really. I tend to keep the release notes only with code or behavioural changes however. |
Sounds good - noted for the future. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes: