Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add broken link checking Action #700

Merged
merged 2 commits into from
Jul 25, 2022
Merged

Conversation

wolf99
Copy link
Contributor

@wolf99 wolf99 commented May 14, 2022

Also adjusts the entire workflow to only run if a PR or push contains changes to a markdown file.

This will require the addition of an access token in the repository, if one does not already exist. The token is used to avoid rate-limiting by GitHub when the Lychee Action uses the GitHub API. Further info in the comments in the change.

@wolf99
Copy link
Contributor Author

wolf99 commented May 14, 2022

Lots of URLs that are in code blocks are failing. My understanding is that Lychee should automatically ignore code blocks, so I have raised an issue on the Lychee Action: lycheeverse/lychee-action#117 .

Moving this to draft until this is resolved.

@wolf99 wolf99 marked this pull request as draft May 14, 2022 20:33
@wolf99
Copy link
Contributor Author

wolf99 commented Jun 25, 2022

Oh man, the godaddy and globalsign websites suck.

@wolf99
Copy link
Contributor Author

wolf99 commented Jun 25, 2022

@ldennington the link checker fails this GitLab link (https://github.com/GitCredentialManager/git-credential-manager/blob/main/docs/faq.md?plain=1#L158) because it is only accessible to a logged in user. I could try to tell the checker to ignore it, but there would then be no warning if GitLab were to change the URL.

Options:

  1. Ignore it and take the risk. This is the same as the current situation where there is no link checker
  2. Remove the URL and rely on the prose description only. This suffers the same problem really as the prose would need updating if GitLab changed where these settings are.

As the risk is essentially the same either way, I suggest option 1. I would like to get your thought on it, as maybe there are other options that I am not aware of?

@wolf99 wolf99 marked this pull request as ready for review June 26, 2022 20:07
@ldennington
Copy link
Contributor

As the risk is essentially the same either way, I suggest option 1. I would like to get your thought on it, as maybe there are other options that I am not aware of?

I agree that we should go with option 1. I did a quick search, and I'm not seeing any instructions for revoking OAuth Application access in GitLab's docs, which means we'll need to stick with these DIY instructions. Although the link checker thinks this is problematic, the docs are ultimately intended for our users, and I think they will find the link helpful 🙂.

Also adjusts the entire workflow to only run if a PR or push contains changes to a markdown file
@wolf99
Copy link
Contributor Author

wolf99 commented Jul 24, 2022

Rebased and now ignores the specific GitLab URL as agreed, so this is good to go.
Apologies for the delay, I've been moving across the country 🙂 .

@mjcheetham
Copy link
Collaborator

Thanks for this! Broken links are a pain which should be avoided now :-)

@mjcheetham mjcheetham merged commit 10935fb into git-ecosystem:main Jul 25, 2022
@wolf99 wolf99 deleted the link-checker branch October 8, 2022 19:26
@ldennington ldennington mentioned this pull request Nov 3, 2022
ldennington added a commit that referenced this pull request Nov 3, 2022
Changes:

- Check for broken links in documentation (#700)
- Support macOS `arm64` installs via Homebrew (#798) 
- Validate installers before publishing (#813)
- Auto-generate maintainer away notification issues (#842)
- Install dotnet via Jammy feeds on Ubuntu 22.04 and greater (#839)
- Access Azure storage account using service principle credentials
(#851)
- Update documentation to use reference-style links (#680)
- Unify documentation line length (#862)
- Add generic username/password UI (#871)
- Bitbucket DC OAuth support (#607)
- Distribute GCM as a dotnet tool (#886)
- Drop `-core` suffix from entry executable #551 
- Speed up build graph (#924)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants