Add generic username/password UI to all platforms #871
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For some reason on macOS windows that are activated are not appearing on top, and get lost behind other application windows. The platform implementation on macOS is seemingly correctly calling the `makeKeyAndOrderFront` native windowing API, but it's not being made "key and front". Setting the "topmost" flag true (and then false again) brings our windows to the front, which is what we want.
Include the images resource across all the Avalonia UI applications.
9 tasks
mjcheetham
commented
Sep 23, 2022
ldennington
approved these changes
Sep 23, 2022
| @@ -37,6 +30,6 @@ | |||
| <TextBlock HorizontalAlignment="Center" | |||
| Margin="0,10,0,0" | |||
| FontSize="11" | |||
| Text="Copyright © Microsoft Corporation"/> | |||
| Text="Copyright © GitHub"/> | |||
| ); | ||
|
|
||
| AddOption( | ||
| new Option("--no-logo", "Hide the Git Credential Manager logo and logotype.") |
There was a problem hiding this comment.
Is there a reason this is --no-logo rather than --logo?
There was a problem hiding this comment.
I guess the default being 'show the logo'?
| <ProjectReference Include="..\Core.UI.Windows\Core.UI.Windows.csproj" /> | ||
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="'$(OSPlatform)' != 'windows'"> |
There was a problem hiding this comment.
Will this ever be the case?
There was a problem hiding this comment.
Yes, sadly.. opening the solution in some IDEs (*cough* VSMac *cough*) the projects are still built/restored even if the solution configuration isn't in WindowDebug/Release... :(
Add a generic credentials prompt view model and command for collecting username/passwords.
Add an Avalonia-based UI prompt for the generic/basic credential prompt.
Add a WPF/Windows UI prompt for the generic/basic username and password prompt.
Replace calls to the native system UI prompts with shelling out to the generic helper UI.
mjcheetham
force-pushed
the
generic-ui
branch
from
5149f73
to
feb02ce
Compare
Merged
ldennington
added a commit
that referenced
this pull request
Nov 3, 2022
Changes: - Check for broken links in documentation (#700) - Support macOS `arm64` installs via Homebrew (#798) - Validate installers before publishing (#813) - Auto-generate maintainer away notification issues (#842) - Install dotnet via Jammy feeds on Ubuntu 22.04 and greater (#839) - Access Azure storage account using service principle credentials (#851) - Update documentation to use reference-style links (#680) - Unify documentation line length (#862) - Add generic username/password UI (#871) - Bitbucket DC OAuth support (#607) - Distribute GCM as a dotnet tool (#886) - Drop `-core` suffix from entry executable #551 - Speed up build graph (#924)
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Introduce a new GUI prompt for capturing basic credentials (username/password) on all platforms, using Avalonia UI on Mac & Linux, and WPF on Windows. Today we only have text-based support across all platforms, and a GUI prompt on Windows provided by the
CredUIPromptForWindowsCredentialsWindows API.The Windows API has some shortcomings and behaviour that we cannot override, including that if the entered username matches a local Windows user account name, it'll be prefixed with the domain if the machine is joined (for example
DOMAIN\LOCALUSER).WPF/Windows (left: new, right: old)
AvaloniaUI (Mac/Linux)
Fixes #799 #319