Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perl: prepare for v5.36 #57

Merged
merged 2 commits into from
Jul 27, 2022
Merged

perl: prepare for v5.36 #57

merged 2 commits into from
Jul 27, 2022

Conversation

dscho
Copy link
Member

@dscho dscho commented Jul 26, 2022

This not only rebases the patches, but also fixes a couple of test failures.

At the same time, ./patchprov was run, to update the provides array in the PKGBUILD file. This run failed because there was still a "patch" to a file in the Pod-Parser module even while that module was no longer included even in Perl v5.32.x. So this was fixed, too.

This closes git-for-windows/git#3874

@dscho dscho self-assigned this Jul 26, 2022
@dscho dscho force-pushed the perl-5.36 branch 2 times, most recently from b5927f1 to e092a0c Compare July 27, 2022 07:33
The default location of the full 32-bit Git for Windows SDK has changed
from `C:\git-sdk-32-full-sdk` to `C:\git-sdk-32`.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
This not only rebases the patches, but also fixes a all test failures.
This required dropping that `sed` call from `PKGBUILD` that messed up
all trailing whitespace (including the whitespace required by the tests,
e.g. where TAB-delimited lines ended in an empty value, i.e. in a
horizontal tab).

At the same time, `./patchprov` was run, which pointed out that there
was still a "patch" to a file in the `Pod-Parser` module even while that
module was no longer included even in Perl v5.32.x (and hence that patch
actually created the no-longer-needed file).

In the process, a bug was fixed in `patchprov` where it downcased all
Perl package names.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho dscho merged commit b40247b into git-for-windows:main Jul 27, 2022
@dscho dscho deleted the perl-5.36 branch July 27, 2022 10:13
@dscho
Copy link
Member Author

dscho commented Jul 27, 2022

The test suite finally passes!

The perl package is being built and uploaded.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
1 participant