Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Un-deprecate Git CMD #275

Merged
merged 1 commit into from
Jan 30, 2020
Merged

Conversation

dscho
Copy link
Member

@dscho dscho commented Jan 29, 2020

The reason to deprecate Git CMD went away as of git-for-windows/MINGW-packages@82172388b. So let's revert the deprecation.

The reason why Git CMD was deprecated: we originally thought it would be
_impossible_ to override the default where running `git show` in a
directory containing, say, a `git.cmd` script would _not_ run the
intended `git.exe`, which was considered a security issue.

As of git-for-windows/MINGW-packages@82172388b
(git: prevent Git CMD from picking up git.exe in the local directory,
2018-11-22), we however _do_ have a way to prevent this vulnerability.

So let's just remove the "(Deprecated)" label from `Git CMD` because the
reason for it no longer exists.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Copy link
Collaborator

@bbolli bbolli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see no problems with this patch, provided that doskey is available on all supported Windows versions.

@dscho
Copy link
Member Author

dscho commented Jan 30, 2020

I see no problems with this patch, provided that doskey is available on all supported Windows versions.

I am pretty certain that it is: https://en.wikipedia.org/wiki/DOSKEY#History

@dscho dscho merged commit b00d222 into git-for-windows:master Jan 30, 2020
@dscho dscho deleted the un-deprecate-git-cmd branch January 30, 2020 09:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants