Upgrade users to Git Credential Manager Core #305
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Git Credential Manager for Windows (or short: GCM(W)) is quite popular, but due to its reliance on .NET Framework, it is limited to Windows by nature. To fix this, Git Credential Manager Core was started, based on .NET Core, therefore inherently cross-platform. It is the designated successor of Git Credential Manager for Windows. GitHub announced that password-based HTTP basic authentication is deprecated and will be removed "in an upcoming release": https://github.blog/changelog/2019-08-08-password-based-http-basic-authentication-deprecation-and-removal/ This forces our hand, as GCM(W) only supports password-based HTTP basic authentication, while GCM Core supports OAuth-based authentication. So let's upgrade all existing users to Git Credential Manager Core before they receive nag mails (to stave off hundreds if not thousands of "bug" reports). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
We just modified the installer to upgrade users of GCM(W) to GCM Core. Let's do the same for helper-selector users. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
When `git-credential-helper-selector` is not available, we used to choose GCM(W) as default credential helper. Let's imitate the installer in upgrading GCM(W) users to GCM Core, for the same reasons. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
mjcheetham
approved these changes
Sep 30, 2020
GCM Core is the recommended choice now. Let's make that clear from the beginning. Suggested by Matthew Cheetham. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Since the "(DEPRECATED)" prefix was added, the text had been cut off on the right side. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Good idea! Done. It looks like this now: |
dscho
added a commit
that referenced
this pull request
Sep 30, 2020
Existing Git Credential Manager for Windows users are now [automatically upgraded](#305) to [Git Credential Manager Core](https://github.com/microsoft/git-credential-manager-core/). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to git-for-windows/git-sdk-64
that referenced
this pull request
Dec 1, 2020
See git-for-windows/build-extra#305. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
added a commit
to git-for-windows/git-sdk-32
that referenced
this pull request
Dec 1, 2020
See git-for-windows/build-extra#305. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As per GitHub's announcement, password-based authentication is deprecated and will be removed in the near future.
Git Credential Manager for Windows (which is currently still the recommended default in Git for Windows) only supports that method when authenticating with GitHub, and it is unlikely that it will ever learn any other method: Git Credential Manager Core is the designated successor and all of the development effort goes into that project.
So let's upgrade Git Credential Manager for Windows users to Git Credential Manager Core in Git for Windows v2.29.0; upgrading in any later version would most likely be missing the date when GitHub turns off password-based authentication, and that in turn would most likely cause a lot of turmoil with our users.