Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

git-extra/wordpad: teach wordpad how to deal with spaces in path #378

Merged
merged 1 commit into from Sep 6, 2021

Conversation

carenas
Copy link
Contributor

@carenas carenas commented Sep 5, 2021

When wordpad path has spaces (ex: C:\Program Files\Windows NT),
invoking the binary will fail.

Add quotes around the $WORDPAD variable to avoid that.

Signed-off-by: Carlo Marcelo Arenas Belón carenas@gmail.com

When wordpad path has spaces (ex: C:\Program Files\Windows NT\),
invoking the binary will fail.

Add quotes around the $WORDPAD variable to avoid that.

Signed-off-by: Carlo Marcelo Arenas Belón <carenas@gmail.com>
@dscho dscho merged commit b8bb757 into git-for-windows:main Sep 6, 2021
@dscho
Copy link
Member

dscho commented Sep 6, 2021

Thank you!

@dscho
Copy link
Member

dscho commented Sep 6, 2021

The package is being built and uploaded.

@carenas carenas deleted the wordpad branch September 6, 2021 17:57
dscho added a commit that referenced this pull request Sep 8, 2021
Wordpad [can be configured as Git's preferred
editor](#378) again.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants