installer: upgrade to using InnoSetup v6.3.2 #562
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This version fixes a support function that we do not use (`TStream.Seek`, see https://jrsoftware.org/files/is6-whatsnew.htm for more details), but it's better to stay up to date than linger. Incidentally, this also adds the Korean translations (which we also don't use) which were apparently added in v6.3.0 but the file was not committed at that time, apparently. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
InnoSetup-6.3.2
branch
2 times, most recently
from
9f7f1f7
to
542a16e
Compare
I am puzzled that updating the files in `installer/InnoSetup/` does not trigger a build of the `installer` artifact. The log of the build at https://github.com/git-for-windows/build-extra/actions/runs/9742501717/job/26883944668?pr=562 is not helpful enough to diagnose this, so let's make the log more verbose. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
... even if it is in a subdirectory, such as `installer/InnoSetup/`. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This version fixes a support function that we do not use (
TStream.Seek, see https://jrsoftware.org/files/is6-whatsnew.htm for more details), but it's better to stay up to date than linger.Incidentally, this PR also adds the previously-forgotten Korean translations (which we also don't use) which were apparently added in v6.3.0 but the file was not committed at that time, apparently.