fixup! built-in add -i: implement the main loop

Whoops, a buffer overrun. Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows · Nov 14, 2019 · 0cf5b03 · 0cf5b03
1 parent cca070d
commit 0cf5b03
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/add-interactive.c b/add-interactive.c
@@ -343,7 +343,8 @@ static ssize_t list_and_choose(struct add_i_state *s,
 				}
 			}
 
-			p[sep] = '\0';
+			if (p[sep])
+				p[sep++] = '\0';
 			if (from < 0) {
 				from = find_unique(p, items);
 				if (from >= 0)
@@ -369,7 +370,7 @@ static ssize_t list_and_choose(struct add_i_state *s,
 					res += choose ? +1 : -1;
 				}
 
-			p += sep + 1;
+			p += sep;
 		}
 
 		if ((immediate && res != LIST_AND_CHOOSE_ERROR) ||