Skip to content

Commit

Permalink
mingw: allow for longer paths in parse_interpreter()
Browse files Browse the repository at this point in the history
As reported in newren/git-filter-repo#225, it
looks like 99 bytes is not really sufficient to represent e.g. the full
path to Python when installed via Windows Store (and this path is used
in the hasb bang line when installing scripts via `pip`).

Let's increase it to what is probably the maximum sensible path size:
MAX_PATH. This makes `parse_interpreter()` in line with what
`lookup_prog()` handles.

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Vilius Šumskas <vilius@sumskas.eu>
  • Loading branch information
dscho committed Sep 22, 2022
1 parent 0f63eac commit ffdce9b
Showing 1 changed file with 1 addition and 1 deletion.
2 changes: 1 addition & 1 deletion compat/mingw.c
Expand Up @@ -1247,7 +1247,7 @@ static const char *quote_arg_msys2(const char *arg)

static const char *parse_interpreter(const char *cmd)
{
static char buf[100];
static char buf[MAX_PATH];
char *p, *opt;
int n, fd;

Expand Down

0 comments on commit ffdce9b

Please sign in to comment.