error on git init with soft link in git template dir

[Konfekt]

Setup

git version 2.33.0.windows.2 64bit on Windows 10

git version 2.31.1
cpu: x86_64
no commit associated with this build
sizeof-long: 8
sizeof-size_t: 8
shell-path: /bin/sh

• Which version of Windows are you running? Vista, 7, 8, 10? Is it 32-bit or 64-bit?

Microsoft Windows [Version 10.0.19043.1052]

Editor Option: VIM
Custom Editor Path:
Default Branch Option:
Path Option: Cmd
SSH Option: OpenSSH
Tortoise Option: false
CURL Option: OpenSSL
CRLF Option: CRLFAlways
Bash Terminal Option: ConHost
Git Pull Behavior Option: Merge
Use Credential Manager: Core
Performance Tweaks FSCache: Enabled
Enable Symlinks: Enabled
Enable Pseudo Console Support: Disabled
Enable FSMonitor: Disabled

Details

Using cmd or Powershell and having a soft link from hooks/post-applypatch to hooks/post-commit in $GIT_TEMPLATE_DIR, calling git init in the directory C:\Users\konfekt\repo gives the error message

fatal: cannot symlink 'post-commit' 'C:/Users/konfekt/repo/.git/hooks/post-applypatch': Function not implemented

and no git repo was created. Expected was a git repo.

[dscho]

fatal: cannot symlink 'post-commit' 'C:/Users/konfekt/repo/.git/hooks/post-applypatch': Function not implemented

Git for Windows does not ship with an enabled post-applypatch:

$ ls -l /mingw64/share/git-core/templates/hooks/
total 45
-rwxr-xr-x 1 me@work 4096  478 Aug 24 10:09 applypatch-msg.sample*
-rwxr-xr-x 1 me@work 4096  896 Aug 24 10:09 commit-msg.sample*
-rwxr-xr-x 1 me@work 4096 4655 Aug 24 10:09 fsmonitor-watchman.sample*
-rwxr-xr-x 1 me@work 4096  189 Aug 24 10:09 post-update.sample*
-rwxr-xr-x 1 me@work 4096  424 Aug 24 10:09 pre-applypatch.sample*
-rwxr-xr-x 1 me@work 4096 1643 Aug 24 10:09 pre-commit.sample*
-rwxr-xr-x 1 me@work 4096  416 Aug 24 10:09 pre-merge-commit.sample*
-rwxr-xr-x 1 me@work 4096 1374 Aug 24 10:09 pre-push.sample*
-rwxr-xr-x 1 me@work 4096 4898 Aug 24 10:09 pre-rebase.sample*
-rwxr-xr-x 1 me@work 4096  544 Aug 24 10:09 pre-receive.sample*
-rwxr-xr-x 1 me@work 4096 1492 Aug 24 10:09 prepare-commit-msg.sample*
-rwxr-xr-x 1 me@work 4096 2783 Aug 24 10:09 push-to-checkout.sample*
-rwxr-xr-x 1 me@work 4096 3650 Aug 24 10:09 update.sample*

Therefore, your report is missing crucial details and there is little anybody can do to help before the missing information is filled in. As a matter of fact, I would like to encourage you to overshare information about your setup, and quite possibly try to come up with a small shell script that reproduces this issue outside of your particular setup (probably using git init --template=<directory> because as I said: by default, Git for Windows does not display the behavior you described).

[Konfekt]

Yes, the issue is not there with a default Git for Windows installation. However, once having a soft link in $GIT_TEMPLATE_DIR, say from hooks/post-applypatch to hooks/post-commit, it shows up under the above configuration.
To reproduce, inside the cmd shell, type

git config --global init.templatedir %USERPROFILE%/.git/templates
mkdir %USERPROFILE%/.git/templates/hooks
cd hooks
type nul >> post-commit
mklink post-applypatch post-commit
cd %USERPROFILE$
mkdir repo
cd repo
git init

[dscho]

mkdir %USERPROFILE%/.git/templates/hooks

This complains with this message: The syntax of the command is incorrect.

cd %USERPROFILE$

I don't think that works with the dollar instead of the percent sign.

It would have been nice if I hadn't needed to spend time to fix the reproducer and could have focused immediately on the bug. As it is, I now can reproduce the bug and am fairly certain that this patch would fix it (I opened #3417 but I have no more time to spend on this issue today):

diff --git a/builtin/clone.c b/builtin/clone.c
index 3d82abf6c42b..e5d673ec9923 100644
--- a/builtin/clone.c
+++ b/builtin/clone.c
@@ -990,7 +990,7 @@ int cmd_clone(int argc, const char **argv, const char *prefix)
 	struct transport_ls_refs_options transport_ls_refs_options =
 		TRANSPORT_LS_REFS_OPTIONS_INIT;
 
-	git_config(platform_core_config, NULL);
+	git_config(git_default_core_config, NULL);
 
 	packet_trace_identity("clone");
 
diff --git a/builtin/column.c b/builtin/column.c
index 9898d9adba48..b7833c0df5f7 100644
--- a/builtin/column.c
+++ b/builtin/column.c
@@ -34,7 +34,7 @@ int cmd_column(int argc, const char **argv, const char *prefix)
 		OPT_END()
 	};
 
-	git_config(platform_core_config, NULL);
+	git_config(git_default_core_config, NULL);
 
 	/* This one is special and must be the first one */
 	if (argc > 1 && starts_with(argv[1], "--command=")) {
diff --git a/builtin/init-db.c b/builtin/init-db.c
index 90aef85291d0..848031d8b0ca 100644
--- a/builtin/init-db.c
+++ b/builtin/init-db.c
@@ -410,7 +410,7 @@ int init_db(const char *git_dir, const char *real_git_dir,
 	startup_info->have_repository = 1;
 
 	/* Ensure `core.hidedotfiles` is processed */
-	git_config(platform_core_config, NULL);
+	git_config(git_default_core_config, NULL);
 
 	safe_create_dir(git_dir, 0);
 
diff --git a/config.c b/config.c
index 19f1d719c81d..16840e273a48 100644
--- a/config.c
+++ b/config.c
@@ -1295,7 +1295,7 @@ int git_config_color(char *dest, const char *var, const char *value)
 	return 0;
 }
 
-static int git_default_core_config(const char *var, const char *value, void *cb)
+int git_default_core_config(const char *var, const char *value, void *cb)
 {
 	/* This needs a better name */
 	if (!strcmp(var, "core.filemode")) {
diff --git a/config.h b/config.h
index 110c426b0825..ae1aa0f8779b 100644
--- a/config.h
+++ b/config.h
@@ -120,6 +120,7 @@ struct config_options {
 typedef int (*config_fn_t)(const char *, const char *, void *);
 
 int git_default_config(const char *, const char *, void *);
+int git_default_core_config(const char *var, const char *value, void *cb);
 
 /**
  * Read a specific file in git-config format.

[Konfekt]

Thank you very much and pardon the typos!