Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

russian and other locales support #584

Closed
stamepicmorg opened this issue Dec 29, 2015 · 8 comments
Closed

russian and other locales support #584

stamepicmorg opened this issue Dec 29, 2015 · 8 comments

Comments

@stamepicmorg
Copy link

Hello.
Is it possible to add language support for the Russian language in the new version?
It was at all "msysgit" pre-releases, and it exists in the current SDK.

Thanks.

@stamepicmorg stamepicmorg changed the title russian and other locales russian and other locales support Dec 29, 2015
@Aleks-Z
Copy link

Aleks-Z commented Dec 29, 2015

Same trouble

@kostix
Copy link

kostix commented Dec 29, 2015

@Aleks-Z, please refrain from "me too"-style comments. They pollute the issue tracker, add nothing to the discussion and actually do not affect the motivation of those who are able to fix things -- quite contrary, they might make them angry.

@kostix
Copy link

kostix commented Dec 29, 2015

@stamepicmorg, were #496, #403, #378 not enough to cover this problem? What warranted creating another issue?

@stamepicmorg
Copy link
Author

sorry but the problem is not solved..

In one issue, the author refers to the lightweight installer.
The other - the fact that it is "Open source".

So the final decision and has not followed.

@stamepicmorg
Copy link
Author

What prevents the installer to create a second with only localizations?

Or, as has been previously suggested to make two versions of the installer - portable (current) and complete?

At each issues a new answer.


And yes - a can manually install locales. I know it..

@stamepicmorg stamepicmorg reopened this Dec 29, 2015
@stamepicmorg
Copy link
Author

hmmm. ok. can i try to create standalone installer of languages and if it will be work fine i will add it as pull request at "build-extra" repository?

@dscho
Copy link
Member

dscho commented Dec 30, 2015

These questions have been answered already, with WITH_L10N=1 being the flag to use when generating the installers and portable Gits.

If you truly care about this issue, here is the way to go forward:

  1. make an installer
  2. patch the script that is used to put together new Git for Windows releases (/usr/src/build-extra/please.sh) to generate localised installers/portable Gits, too (basically just search for PortableGit-, bonus points for refactoring the enumeration of the installer/portable Git files).
  3. verify that your changes work (you will need both 32-bit and 64-bit SDKs for that)
  4. commit, push & open a Pull Request

I am curious to see your progress.

@stamepicmorg
Copy link
Author

@dscho Thank you for answer! I will really try it.

Sorry for my bad English, Merry Christmas and Happy New Year!

dscho pushed a commit to dscho/git that referenced this issue Jul 11, 2023
Migrate applicable secrets to a new 'release' workflow environment. This
is a security measure to help ensure secrets cannot be accessed by those
without proper permissions.

An example of a passing `build-git-installers` workflow with these
changes can be found
[here](https://github.com/ldennington/git/actions/runs/5182147378) (I
set up my fork with the same migrated secret values as this repo).

Note that the old actions secrets will be left in this repo until the
next successful release, at which point they can be safely removed.
dscho pushed a commit to dscho/git that referenced this issue Aug 8, 2023
Migrate applicable secrets to a new 'release' workflow environment. This
is a security measure to help ensure secrets cannot be accessed by those
without proper permissions.

An example of a passing `build-git-installers` workflow with these
changes can be found
[here](https://github.com/ldennington/git/actions/runs/5182147378) (I
set up my fork with the same migrated secret values as this repo).

Note that the old actions secrets will be left in this repo until the
next successful release, at which point they can be safely removed.
dscho pushed a commit to dscho/git that referenced this issue Aug 9, 2023
Migrate applicable secrets to a new 'release' workflow environment. This
is a security measure to help ensure secrets cannot be accessed by those
without proper permissions.

An example of a passing `build-git-installers` workflow with these
changes can be found
[here](https://github.com/ldennington/git/actions/runs/5182147378) (I
set up my fork with the same migrated secret values as this repo).

Note that the old actions secrets will be left in this repo until the
next successful release, at which point they can be safely removed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants