Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows "File version" metadata incorrect for git.exe #723

Closed
1 task done
daxelrod opened this issue Apr 8, 2016 · 4 comments
Closed
1 task done

Windows "File version" metadata incorrect for git.exe #723

daxelrod opened this issue Apr 8, 2016 · 4 comments

Comments

@daxelrod
Copy link

daxelrod commented Apr 8, 2016

  • I was not able to find an open
    or closed issue
    matching what I'm seeing

Setup

  • Which version of Git for Windows are you using? 32-bit or 64-bit? Include the
    output of git version as well.

64 bit

$ git --version
git version 2.7.4.windows.1
  • Which version of Windows are you running? 32-bit or 64-bit?

Windows 7 Enterprise Service Pack 1, 64 bit

  • What options did you set as part of the installation? Or did you choose the
    defaults?

Here is the ini used by the installer with the /loadinf flag

[Setup]
Lang=default
Dir=C:\Program Files\Git
Group=Git
NoIcons=0
SetupType=default
Components=ext,ext\shellhere,ext\guihere,assoc,assoc_sh
Tasks=
PathOption=Cmd
SSHOption=OpenSSH
CRLFOption=CRLFAlways
BashTerminalOption=MinTTY
PerformanceTweaksFSCache=Disabled
  • Any other interesting things about your environment that might be related
    to the issue you're seeing?

Not that I know of.

Details

  • Which terminal/shell are you running Git from? e.g Bash/CMD/PowerShell/other

Any

  1. Right-click on C:\Program Files\Git\cmd\git.exe in Windows Explorer
  2. Choose Properties
  3. Choose Details tab
  4. Examine File version and Product version.
    • What did you expect to occur after running these commands?

I expected "File version" to be some variant of 2.7.4. Note that "Product version" is correctly set to 2.7.4.windows.1.

  • What actually happened instead?

"File version" was 2.7.0.0.

git-exe-properties

  • If the problem was occurring with a specific repository, can you provide the
    URL to that repository to help us with testing?

No

Rationale

We'd like to restrict which versions of Git are allowed to run via Windows Group Policy (to prevent versions vulnerable to CVE-2016-2324 and CVE-2016-2315 from running). Group Policy is only able to detect versions based upon "File version", not "Product version".

Thank you!

@whoisj
Copy link

whoisj commented Apr 13, 2016

Does this reproduce with the latest version of Git for Windows?

@landstander668
Copy link

@whoisj I just checked the current version (2.8.1.windows.1 64-bit), and the Properties/Details tab shows "2.8.0.0" for File Version.

@whoisj
Copy link

whoisj commented Apr 14, 2016

Interesting. I do see the "File Version" to be "2.8.0.0", but I also see Product Version to be "2.8.1.windows.1".

image

@dscho dscho closed this as completed in 83fc7d0 Apr 14, 2016
@daxelrod
Copy link
Author

Thank you very much!

dscho added a commit that referenced this issue Apr 30, 2016
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue May 20, 2016
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue May 25, 2016
This fixes git-for-windows#723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Jun 7, 2016
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Jun 9, 2016
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Jun 9, 2016
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Jun 9, 2016
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Jun 9, 2016
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Jun 14, 2016
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Jul 12, 2016
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Jul 16, 2016
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Jul 23, 2016
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Jul 23, 2016
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Jul 23, 2016
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Jul 27, 2016
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Jul 27, 2016
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Jul 29, 2016
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Aug 2, 2016
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Aug 2, 2016
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Aug 2, 2016
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Aug 2, 2016
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Sep 11, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Sep 12, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Sep 19, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows-ci pushed a commit that referenced this issue Sep 20, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Sep 20, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows-ci pushed a commit that referenced this issue Sep 21, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows-ci pushed a commit that referenced this issue Sep 21, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows-ci pushed a commit that referenced this issue Sep 26, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows-ci pushed a commit that referenced this issue Sep 26, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Sep 26, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Oct 17, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Oct 19, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Oct 19, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Oct 19, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Oct 19, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Oct 19, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows-ci pushed a commit that referenced this issue Oct 20, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows-ci pushed a commit that referenced this issue Oct 20, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows-ci pushed a commit that referenced this issue Oct 20, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Oct 20, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows-ci pushed a commit that referenced this issue Oct 21, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Oct 23, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows-ci pushed a commit that referenced this issue Oct 24, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this issue Oct 30, 2017
This fixes #723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit to dscho/git that referenced this issue Oct 30, 2017
This fixes git-for-windows#723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
gitster pushed a commit to git/git that referenced this issue Nov 1, 2017
This fixes git-for-windows#723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Signed-off-by: Junio C Hamano <gitster@pobox.com>
fengguang pushed a commit to 0day-ci/git that referenced this issue Nov 1, 2017
This fixes git-for-windows#723

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants
@daxelrod @landstander668 @whoisj and others