Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make sure errno is set when socket operations fail #2405

Merged
merged 1 commit into from
Nov 25, 2019

Commits on Nov 25, 2019

  1. mingw: make sure errno is set correctly when socket operations fail

    The winsock2 library provides functions that work on different data
    types than file descriptors, therefore we wrap them.
    
    But that is not the only difference: they also do not set `errno` but
    expect the callers to enquire about errors via `WSAGetLastError()`.
    
    Let's translate that into appropriate `errno` values whenever the socket
    operations fail so that Git's code base does not have to change its
    expectations.
    
    This closes git-for-windows#2404
    
    Helped-by: Jeff Hostetler <jeffhost@microsoft.com>
    Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
    dscho committed Nov 25, 2019
    Configuration menu
    Copy the full SHA
    c11f75c View commit details
    Browse the repository at this point in the history