Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

git-artifacts: don't add ARM64-specific workaround for GCM Core in skipped jobs #3152

Merged
merged 1 commit into from
Mar 31, 2021
Merged

git-artifacts: don't add ARM64-specific workaround for GCM Core in skipped jobs #3152

merged 1 commit into from
Mar 31, 2021

Conversation

dscho
Copy link
Member

@dscho dscho commented Mar 28, 2021

In skipped jobs, the arm64/ directory does not exist, which would make this task fail: https://github.com/dscho/git/runs/2214202079?check_suite_focus=true

Cc: @dennisameling

@dscho
fixup! git-artifacts: add workaround for GCM Core on ARM64
dc76457 
We should not try to write that workaround if we're skipping the current
matrix job... In that case, `arm64/` wouldn't exist, anyway...

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
@dscho
Copy link
Member Author

dscho commented Mar 28, 2021

@dennisameling speaking of that build, could I bother you to verify that the MinGit artifact from that build works? I am particularly interested in verifying that #3151 does not break anything. So if you could test that git-shell.exe and git.exe do run correctly, whether run from bin/ or from libexec/git-core/, that would be lovely!

@dscho dscho merged commit 8b8cd53 into git-for-windows:main Mar 31, 2021
@dscho dscho deleted the fix-selective-arm64-git-artifacts branch March 31, 2021 13:59
@dennisameling
Copy link

@dscho sorry for the late reply, have been swamped with work lately. Please give me a few days to test #3151 and get back to other things here!

@dennisameling
Copy link

dennisameling commented Apr 19, 2021 •
edited
Loading

@dscho alright, finally got to testing the ARM64 MinGit artifact from #3151 😊 All looking good:

PS C:\Users\denni\Downloads\mingit-arm64\arm64\bin> .\git.exe version
git version 2.31.1.GIT
PS C:\Users\denni\Downloads\mingit-arm64\arm64\bin> .\git-shell.exe
git>
PS C:\Users\denni\Downloads\mingit-arm64\arm64\libexec\git-core> .\git.exe version
git version 2.31.1.GIT
PS C:\Users\denni\Downloads\mingit-arm64\arm64\libexec\git-core> .\git-shell.exe
git>

Once again sorry for the delay!

@dscho
Copy link
Member Author

dscho commented Apr 20, 2021

Thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dscho @dennisameling