gpg-interface: trim CR from ssh-keygen -Y find-principals

[martelletto]

It looks like we need to trim \r from the output of ssh-keygen -Y find-principals's on Windows, or we end up calling ssh-keygen -Y verify with a bogus signer identity, as per screenshot. ssh-keygen.c:2841 seems to confirm this hypothesis. Signature verification passes with the fix.

Apologies if this isn't the appropriate forum, and thank you for your work on Git for Windows!

-p.

[dscho]

It looks like we need to trim \r from the output of ssh-keygen -Y find-principals's on Windows, or we end up calling ssh-keygen -Y verify with a bogus signer identity, as per screenshot. ssh-keygen.c:2841 seems to confirm this hypothesis. Signature verification passes with the fix.

That looks like good material to put into the commit message.

As the DCO bot pointed out, you also need to add your Signed-off-by: trailer.

So: please amend the commit message with git commit -s, providing a thorough commit message, and then force-push.

[martelletto]

Sure; done. Thanks for the feedback.

[dscho]

Thank you!

[dscho]

A new snapshot that includes the fix is now available.

[djmdjm]

There's also https://bugzilla.mindrot.org/show_bug.cgi?id=3094 to make the verifier more lenient

[dscho]

There's also https://bugzilla.mindrot.org/show_bug.cgi?id=3094 to make the verifier more lenient

This will help future OpenSSH versions, but we cannot assume that everybody upgrades immediately. So I think we did the right thing, merging this PR.