Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed masking username with asterisks when reading credentials #677

Merged
merged 1 commit into from Mar 2, 2016
Merged

Fixed masking username with asterisks when reading credentials #677

merged 1 commit into from Mar 2, 2016

Conversation

yaras
Copy link

@yaras yaras commented Feb 29, 2016

Fixes: #675

When reading username PROMPT_ASKPASS is unnecessary.

Signed-off-by: yaras yaras6@gmail.com

After my change, username is asked in command prompt (without asterisks) and user password in Open SSH prompt (with asterisks).

What you think about such solution?

@dscho
Copy link
Member

dscho commented Mar 1, 2016

Thank you for your contribution!

I would like to suggest two changes, both with the commit message:

  1. In Git, the commit subject is preferred to be in imperative form, in this case: Do not mask the username when reading credentials
  2. I would really like the commit message to start with a summary of the bug that was fixed, and only at the very end say "This fixes Git GUI: push, username dialog - asterisks when typing username #675." (which would auto-close the ticket when I merge the PR). That way, the commit message is useful even if the reader is stuck in a place without internet connection.

Could you amend the commit and force-push?

@yaras
Do not mask the username when reading credentials
26b7327 
When user is asked for credentials there is no need to mask username,
so PROMPT_ASKPASS flag on calling credential_ask_one for login is
unnecessary.

credential_ask_one internally uses git_prompt which in case of given
flag PROMPT_ASKPASS uses masked input method instead of
git_terminal_prompt, which does not mask user input.

This fixes git-for-windows#675

Signed-off-by: yaras <yaras6@gmail.com>
@yaras
Copy link
Author

yaras commented Mar 1, 2016

I updated commit message.

Could you check it?

dscho added a commit that referenced this pull request Mar 2, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
47d64e6 
Fixed masking username with asterisks when reading credentials
@dscho dscho merged commit 47d64e6 into git-for-windows:master Mar 2, 2016
@dscho
Copy link
Member

dscho commented Mar 2, 2016

Perfect, thanks!

dscho added a commit to git-for-windows/build-extra that referenced this pull request Mar 2, 2016
@dscho
Mention Bug Fix in release notes
017777e 
We [no longer show asterisks when reading the username for
credentials](git-for-windows/git#677).

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this pull request Mar 15, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
9f3f612 
Fixed masking username with asterisks when reading credentials
dscho added a commit that referenced this pull request Mar 18, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
d6c16ff 
Fixed masking username with asterisks when reading credentials
dscho added a commit that referenced this pull request Mar 29, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
fce9915 
Fixed masking username with asterisks when reading credentials
dscho added a commit that referenced this pull request Apr 4, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
c7f4d21 
Fixed masking username with asterisks when reading credentials
dscho added a commit that referenced this pull request Apr 30, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
69edead 
Fixed masking username with asterisks when reading credentials
dscho added a commit that referenced this pull request May 20, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
5c5674d 
Fixed masking username with asterisks when reading credentials
dscho added a commit that referenced this pull request Jun 7, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
232cbab 
Fixed masking username with asterisks when reading credentials
dscho added a commit that referenced this pull request Jun 9, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
d6eda1f 
Fixed masking username with asterisks when reading credentials
dscho added a commit that referenced this pull request Jun 9, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
3472b0e 
Fixed masking username with asterisks when reading credentials
dscho added a commit that referenced this pull request Jun 9, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
0aec1a8 
Fixed masking username with asterisks when reading credentials
dscho added a commit that referenced this pull request Jun 9, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
110beba 
Fixed masking username with asterisks when reading credentials
dscho added a commit that referenced this pull request Jun 14, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
db19c47 
Fixed masking username with asterisks when reading credentials
dscho added a commit that referenced this pull request Jul 12, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
575d445 
Fixed masking username with asterisks when reading credentials
dscho added a commit that referenced this pull request Jul 16, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
d2d9a0a 
Fixed masking username with asterisks when reading credentials
dscho added a commit that referenced this pull request Jul 23, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
0d7f9a9 
Fixed masking username with asterisks when reading credentials
dscho added a commit that referenced this pull request Jul 23, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
333eba0 
Fixed masking username with asterisks when reading credentials
dscho added a commit that referenced this pull request Jul 23, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
3505f67 
Fixed masking username with asterisks when reading credentials
dscho added a commit that referenced this pull request Jul 27, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
920c964 
Fixed masking username with asterisks when reading credentials
dscho added a commit that referenced this pull request Jul 27, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
b296519 
Fixed masking username with asterisks when reading credentials
dscho added a commit that referenced this pull request Jul 29, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
d7d8d48 
Fixed masking username with asterisks when reading credentials
dscho added a commit that referenced this pull request Aug 2, 2016
@dscho
Merge pull request #677 from yaras/fix-git-675
09b1cc5 
Fixed masking username with asterisks when reading credentials
git-for-windows-ci pushed a commit that referenced this pull request Apr 16, 2019
@dscho
Merge 'unmask-credentials-username'
61a46e5 
This came in via pull request #677 from yaras/fix-git-675

Fixed masking username with asterisks when reading credentials

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows-ci pushed a commit that referenced this pull request Apr 16, 2019
@dscho
Merge 'unmask-credentials-username'
fa4bf04 
This came in via pull request #677 from yaras/fix-git-675

Fixed masking username with asterisks when reading credentials

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this pull request Apr 17, 2019
@dscho
Merge 'unmask-credentials-username'
7db1c2e 
This came in via pull request #677 from yaras/fix-git-675

Fixed masking username with asterisks when reading credentials

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this pull request Apr 17, 2019
@dscho
Merge 'unmask-credentials-username'
baa6476 
This came in via pull request #677 from yaras/fix-git-675

Fixed masking username with asterisks when reading credentials

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this pull request Apr 17, 2019
@dscho
Merge 'unmask-credentials-username'
8705ef8 
This came in via pull request #677 from yaras/fix-git-675

Fixed masking username with asterisks when reading credentials

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows-ci pushed a commit that referenced this pull request Apr 19, 2019
@dscho
Merge 'unmask-credentials-username'
1ae24e0 
This came in via pull request #677 from yaras/fix-git-675

Fixed masking username with asterisks when reading credentials

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows-ci pushed a commit that referenced this pull request Apr 22, 2019
@dscho
Merge 'unmask-credentials-username'
74c8446 
This came in via pull request #677 from yaras/fix-git-675

Fixed masking username with asterisks when reading credentials

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows-ci pushed a commit that referenced this pull request Apr 23, 2019
@dscho
Merge 'unmask-credentials-username'
c08aa58 
This came in via pull request #677 from yaras/fix-git-675

Fixed masking username with asterisks when reading credentials

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this pull request Apr 27, 2019
@dscho
Merge 'unmask-credentials-username'
0c8c098 
This came in via pull request #677 from yaras/fix-git-675

Fixed masking username with asterisks when reading credentials

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this pull request Apr 27, 2019
@dscho
Merge 'unmask-credentials-username'
b820b78 
This came in via pull request #677 from yaras/fix-git-675

Fixed masking username with asterisks when reading credentials

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this pull request Apr 27, 2019
@dscho
Merge 'unmask-credentials-username'
035011c 
This came in via pull request #677 from yaras/fix-git-675

Fixed masking username with asterisks when reading credentials

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this pull request Apr 27, 2019
@dscho
Merge 'unmask-credentials-username'
cbbb568 
This came in via pull request #677 from yaras/fix-git-675

Fixed masking username with asterisks when reading credentials

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this pull request May 7, 2019
@dscho
Merge 'unmask-credentials-username'
c2ec8bf 
This came in via pull request #677 from yaras/fix-git-675

Fixed masking username with asterisks when reading credentials

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho added a commit that referenced this pull request May 7, 2019
@dscho
Merge 'unmask-credentials-username'
43a222e 
This came in via pull request #677 from yaras/fix-git-675

Fixed masking username with asterisks when reading credentials

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
git-for-windows-ci pushed a commit that referenced this pull request May 8, 2019
@dscho
Merge 'unmask-credentials-username'
51867d8 
This came in via pull request #677 from yaras/fix-git-675

Fixed masking username with asterisks when reading credentials

Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@yaras @dscho