exit_process.h: fix handling of SIGINT and SIGTERM (fixes #1219) #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afsmith92
commented
Jan 10, 2018
| if (WaitForSingleObject (process, 10000) == WAIT_OBJECT_0) | ||
| return 0; | ||
| } | ||
| } |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
1 task
Handle SIGINT and SIGTERM by injecting into the process a thread that runs ExitProcess. Use TerminateProcess otherwise. In both cases, enumerate the entire process tree. This fixes git-for-windows/git#1219 Signed-off-by: Adam Smith <afsmith92@gmail.com> Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
dscho
force-pushed
the
afs-fix-process-term
branch
from
5e29d51
to
53e5c03
Compare
dscho
added a commit
to git-for-windows/build-extra
that referenced
this pull request
Jan 10, 2018
Interrupting processes (and their children) using Control+C [is now a lot more robust](git-for-windows/msys2-runtime#16). Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
|
Thank you so much! I squashed the fixup in, and also touched up the commit message a little. |
|
No problem. Thanks for your help! |
|
Is this going to fix mintty/mintty#648? I would be so happy. |
|
@michaelblyons why don't you test it? Git for Windows v2.16.0 was just released. |
|
It does!! Thank you both greatly. ❤️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Handle SIGINT and SIGTERM by injecting into the process
a thread that runs ExitProcess. Use TerminateProcess otherwise.
Signed-off-by: Adam Smith afsmith92@gmail.com