msys2-runtime: restore fast path for current user primary group #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rglidden
changed the title
Commit a5bcfe6 removed an optimization that fetches the default group from the current user token, as it is sometimes not accurate such as when groups like the builtin Administrators group is the primary group. However, removing this optimization causes extremely poor performance when connected to some Active Directory environments. Restored this optimization as the default behaviour, and added a `group: db-accurate` option to `nsswitch.conf` that can be used to disable the optimization in cases where accurate group information is required. This fixes git-for-windows/git#4459 Signed-off-by: Richard Glidden <richard@glidden.org>
dscho
added a commit
to dscho/MSYS2-packages
that referenced
this pull request
Aug 28, 2023
A recent commit removed an optimization from the Cygwin runtime that fetches the default group from the current user token: At times, this is not accurate such as when groups like the builtin Administrators group is the primary group. However, removing this optimization causes extremely poor performance when connected to some Active Directory environments. Reflecting git-for-windows/msys2-runtime#57, this update restores this optimization as the default behaviour. To still allow the user to opt into the correct behavior, a `group: db-accurate` option is provided for `nsswitch.conf`. This fixes git-for-windows/git#4459 Signed-off-by: Johannes Schindelin <johannes.schindelin@gmx.de>
placaze
reviewed
Aug 28, 2023
| for local accounts, Active Directory for domain account. Examples: | ||
| for local accounts, Active Directory for domain account. For the current | ||
| user, the default group is obtained from the current user token to avoid | ||
| additional lookups to the group database. <literal>db-accuarte</literal> |
There was a problem hiding this comment.
Since we do not build the documentation, this can easily be done in a (non-critical) follow-up PR. @placaze how about it?
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Sep 6, 2023
msys2-runtime: restore fast path for current user primary group
dscho
added a commit
to dscho/msys2-runtime
that referenced
this pull request
Nov 29, 2023
msys2-runtime: restore fast path for current user primary group
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit a5bcfe6 removed an optimization that fetches the default group from the current user token, as it is sometimes not accurate such as when groups like the builtin Administrators group is the primary group.
However, removing this optimization causes extremely poor performance when connected to some Active Directory environments.
Restored this optimization as the default behaviour, and added a
group: db-accurateoption tonsswitch.confthat can be used to disable the optimization in cases where accurate group information is required.This fixes git-for-windows/git#4459