Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Give correct error message for unrecognised options #533

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fix: Give correct error message for unrecognised options #533

wants to merge 2 commits into from

Commits on Jul 18, 2019

  1. Fix: Give correct error message for unrecognised options 

    The first unknown thing was always treated as the URL. So in cases where the unrecognised option was before the URL the URL caused the error.
This fixes this by checking the unknown thing if it could be meant as a option. If it is a option it is not set as the URL but produces the error.

In addition two tests are added to check the produced error messages in both cases.

fixes git-ftp#522
    @LukasFritzeDev
    LukasFritzeDev committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    9159372 View commit details
    Browse the repository at this point in the history

  2. Fix: Give better error message for invalid URLs 

    In some cases a URL can be invalid, i.e. when mistyped an option like `+insecure`.
In this cases `fatal: Remote host not set.` was printed as error message.
Now this message says `... is not a valid host URL.` so the user can see what's wrong.
    @LukasFritzeDev
    LukasFritzeDev committed Jul 18, 2019
    Configuration menu
    Copy the full SHA
    086615d View commit details
    Browse the repository at this point in the history