add support for SSH_ASKPASS #2609
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Sep 10, 2024
In commit d2c1c0f of PR git-lfs#1067 the "cloneSSL" test in what is now our t/t-clone.sh test script was changed with the intent that the test should be skipped when it was run in the Travis CI environment. The commit description from that time notes that we could not determine why the test was failing only on that platform, so the decision was made to just ignore the test in that case. Subsequently, similar checks were added to three other tests. First, the "clone ClientCert" test was introduced in PR git-lfs#1893, and as of commit b471566 in that PR it has included an initial check for a Travis CI environment with the intent of skipping the test when it is run there. Next, in commits 9da65c0 of PR git-lfs#2500 and e53e34e of PR git-lfs#2609 the "askpass: push with core.askPass" and "askpass: push with SSH_ASKPASS" tests in what is now our t/t-askpass.sh tests script were amended to skip execution in the Travis CI context. In the case of the latter two tests, this check works as designed; however, in the case of the two tests in t/t-clone.sh, the check is written as a simple "if $TRAVIS" shell statement, rather than one which uses a shell test command or builtin ("test" or "[" or "[["). As described in git-lfs#5658, the result is that when the TRAVIS variable is undefined, these statements always succeed, and so their conditional blocks run, meaning these tests are skipped on all platforms, at least since we migrated our CI jobs to GitHub Actions in PR git-lfs#3808. In previous commits in this PR we have addressed all the latent bugs that have accumulated in these tests since this problem was first introduced, and so we are now in a position to remove both the valid and invalid checks for the TRAVIS environment variable from all of our tests. This should ensure that the full set of tests in both t/t-askpass.sh and t/t-clone.sh run on all our CI and build platforms.
chrisd8088
added a commit
to chrisd8088/git-lfs
that referenced
this pull request
Sep 15, 2024
In commit d2c1c0f of PR git-lfs#1067 the "cloneSSL" test in what is now our t/t-clone.sh test script was changed with the intent that the test should be skipped when it was run in the Travis CI environment. The commit description from that time notes that we could not determine why the test was failing only on that platform, so the decision was made to just ignore the test in that case. Subsequently, similar checks were added to three other tests. First, the "clone ClientCert" test was introduced in PR git-lfs#1893, and as of commit b471566 in that PR it has included an initial check for a Travis CI environment with the intent of skipping the test when it is run there. Next, in commits 9da65c0 of PR git-lfs#2500 and e53e34e of PR git-lfs#2609 the "askpass: push with core.askPass" and "askpass: push with SSH_ASKPASS" tests in what is now our t/t-askpass.sh tests script were amended to skip execution in the Travis CI context. In the case of the latter two tests, this check works as designed; however, in the case of the two tests in t/t-clone.sh, the check is written as a simple "if $TRAVIS" shell statement, rather than one which uses a shell test command or builtin ("test" or "[" or "[["). As described in git-lfs#5658, the result is that when the TRAVIS variable is undefined, these statements always succeed, and so their conditional blocks run, meaning these tests are skipped on all platforms, at least since we migrated our CI jobs to GitHub Actions in PR git-lfs#3808. In previous commits in this PR we have addressed all the latent bugs that have accumulated in these tests since this problem was first introduced, and so we are now in a position to remove both the valid and invalid checks for the TRAVIS environment variable from all of our tests. This should ensure that the full set of tests in both t/t-askpass.sh and t/t-clone.sh run on all our CI and build platforms.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This matches Git's behavior.
SSH_ASKPASSis tried afterGIT_ASKPASSandcore.askpass, according to https://git-scm.com/docs/gitcredentials.