Remove unused pty code #3737
Merged
Remove unused pty code #3737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The code which allocated and used a pty on Unix systems was unused, but it did bring in a dependency on the github.com/kr/pty module. This module is unmaintained and doesn't compile with gccgo. Since we no longer need the pty code or this module, remove both of them.
ttaylorr
approved these changes
Jul 26, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code which allocated and used a pty on Unix systems was unused, but it did
bring in a dependency on the github.com/kr/pty module. This module is
unmaintained and doesn't compile with gccgo. Since we no longer need the pty
code or this module, remove both of them.
Fixes #3735
/cc @glaubitz as reporter