Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused pty code #3737

Merged
merged 1 commit into from
Jul 26, 2019
Merged

Remove unused pty code #3737

merged 1 commit into from
Jul 26, 2019

Conversation

bk2204
Copy link
Member

@bk2204 bk2204 commented Jul 26, 2019

The code which allocated and used a pty on Unix systems was unused, but it did
bring in a dependency on the github.com/kr/pty module. This module is
unmaintained and doesn't compile with gccgo. Since we no longer need the pty
code or this module, remove both of them.

Fixes #3735
/cc @glaubitz as reporter

@bk2204 bk2204 requested a review from a team July 26, 2019 16:35
The code which allocated and used a pty on Unix systems was unused, but
it did bring in a dependency on the github.com/kr/pty module. This
module is unmaintained and doesn't compile with gccgo. Since we no
longer need the pty code or this module, remove both of them.
@bk2204 bk2204 merged commit 2f170f7 into git-lfs:master Jul 26, 2019
@bk2204 bk2204 deleted the remove-pty branch July 26, 2019 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

git-lfs fails to build with gccgo due to the use of _C_int in kr/pty
2 participants